From 24dbc840985b12a8e61e6e190e8508c72d58bcae Mon Sep 17 00:00:00 2001 From: Eric Erfanian Date: Tue, 29 Aug 2017 21:58:45 -0700 Subject: Make incallui/spam a standalone build target Previously incallui/spam was being built directly into the incallui build target. With this CL it's now a standalone build target. This change should make it easier to test spam notifications. Bug: 62937258 Test: N/A Change-Id: I5f238ed7f9a4eaaff4b2a325479d2b6de19bdf07 PiperOrigin-RevId: 165479077 --- java/com/android/incallui/AndroidManifest.xml | 19 -------- .../android/incallui/ReturnToCallController.java | 2 +- java/com/android/incallui/StatusBarNotifier.java | 8 +-- .../incallui/commontheme/res/values/colors.xml | 21 +++++++- .../res/drawable-hdpi/ic_block_grey600_24dp.png | Bin 518 -> 0 bytes .../res/drawable-hdpi/ic_call_end_white_24dp.png | Bin 454 -> 0 bytes .../res/drawable-hdpi/ic_close_grey600_24dp.png | Bin 225 -> 0 bytes .../drawable-hdpi/ic_person_add_grey600_24dp.png | Bin 300 -> 0 bytes .../res/drawable-mdpi/ic_block_grey600_24dp.png | Bin 348 -> 0 bytes .../res/drawable-mdpi/ic_call_end_white_24dp.png | Bin 315 -> 0 bytes .../res/drawable-mdpi/ic_close_grey600_24dp.png | Bin 178 -> 0 bytes .../drawable-mdpi/ic_person_add_grey600_24dp.png | Bin 211 -> 0 bytes .../res/drawable-xhdpi/ic_block_grey600_24dp.png | Bin 690 -> 0 bytes .../res/drawable-xhdpi/ic_call_end_white_24dp.png | Bin 534 -> 0 bytes .../res/drawable-xhdpi/ic_close_grey600_24dp.png | Bin 261 -> 0 bytes .../drawable-xhdpi/ic_person_add_grey600_24dp.png | Bin 341 -> 0 bytes .../res/drawable-xxhdpi/ic_block_grey600_24dp.png | Bin 1029 -> 0 bytes .../res/drawable-xxhdpi/ic_call_end_white_24dp.png | Bin 736 -> 0 bytes .../res/drawable-xxhdpi/ic_close_grey600_24dp.png | Bin 353 -> 0 bytes .../drawable-xxhdpi/ic_person_add_grey600_24dp.png | Bin 485 -> 0 bytes .../res/drawable-xxxhdpi/ic_block_grey600_24dp.png | Bin 1353 -> 0 bytes .../drawable-xxxhdpi/ic_call_end_white_24dp.png | Bin 929 -> 0 bytes .../res/drawable-xxxhdpi/ic_close_grey600_24dp.png | Bin 444 -> 0 bytes .../ic_person_add_grey600_24dp.png | Bin 638 -> 0 bytes .../res/drawable/spam_notification_icon.xml | 34 ------------- .../incallui/res/layout/caller_in_conference.xml | 2 +- java/com/android/incallui/res/values/colors.xml | 3 -- java/com/android/incallui/res/values/strings.xml | 31 ------------ java/com/android/incallui/spam/AndroidManifest.xml | 41 ++++++++++++++++ .../incallui/spam/SpamCallListListener.java | 13 +++-- .../incallui/spam/SpamNotificationActivity.java | 5 +- .../spam/res/drawable/spam_notification_icon.xml | 34 +++++++++++++ .../android/incallui/spam/res/values/strings.xml | 54 +++++++++++++++++++++ 33 files changed, 164 insertions(+), 103 deletions(-) delete mode 100644 java/com/android/incallui/res/drawable-hdpi/ic_block_grey600_24dp.png delete mode 100644 java/com/android/incallui/res/drawable-hdpi/ic_call_end_white_24dp.png delete mode 100644 java/com/android/incallui/res/drawable-hdpi/ic_close_grey600_24dp.png delete mode 100644 java/com/android/incallui/res/drawable-hdpi/ic_person_add_grey600_24dp.png delete mode 100644 java/com/android/incallui/res/drawable-mdpi/ic_block_grey600_24dp.png delete mode 100644 java/com/android/incallui/res/drawable-mdpi/ic_call_end_white_24dp.png delete mode 100644 java/com/android/incallui/res/drawable-mdpi/ic_close_grey600_24dp.png delete mode 100644 java/com/android/incallui/res/drawable-mdpi/ic_person_add_grey600_24dp.png delete mode 100644 java/com/android/incallui/res/drawable-xhdpi/ic_block_grey600_24dp.png delete mode 100644 java/com/android/incallui/res/drawable-xhdpi/ic_call_end_white_24dp.png delete mode 100644 java/com/android/incallui/res/drawable-xhdpi/ic_close_grey600_24dp.png delete mode 100644 java/com/android/incallui/res/drawable-xhdpi/ic_person_add_grey600_24dp.png delete mode 100644 java/com/android/incallui/res/drawable-xxhdpi/ic_block_grey600_24dp.png delete mode 100644 java/com/android/incallui/res/drawable-xxhdpi/ic_call_end_white_24dp.png delete mode 100644 java/com/android/incallui/res/drawable-xxhdpi/ic_close_grey600_24dp.png delete mode 100644 java/com/android/incallui/res/drawable-xxhdpi/ic_person_add_grey600_24dp.png delete mode 100644 java/com/android/incallui/res/drawable-xxxhdpi/ic_block_grey600_24dp.png delete mode 100644 java/com/android/incallui/res/drawable-xxxhdpi/ic_call_end_white_24dp.png delete mode 100644 java/com/android/incallui/res/drawable-xxxhdpi/ic_close_grey600_24dp.png delete mode 100644 java/com/android/incallui/res/drawable-xxxhdpi/ic_person_add_grey600_24dp.png delete mode 100644 java/com/android/incallui/res/drawable/spam_notification_icon.xml create mode 100644 java/com/android/incallui/spam/AndroidManifest.xml create mode 100644 java/com/android/incallui/spam/res/drawable/spam_notification_icon.xml create mode 100644 java/com/android/incallui/spam/res/values/strings.xml (limited to 'java') diff --git a/java/com/android/incallui/AndroidManifest.xml b/java/com/android/incallui/AndroidManifest.xml index 703e5b509..d854a7fc8 100644 --- a/java/com/android/incallui/AndroidManifest.xml +++ b/java/com/android/incallui/AndroidManifest.xml @@ -92,21 +92,6 @@ - - - - - - + + #7E000000 - \ No newline at end of file + + + @color/blocked_contact_background + diff --git a/java/com/android/incallui/res/drawable-hdpi/ic_block_grey600_24dp.png b/java/com/android/incallui/res/drawable-hdpi/ic_block_grey600_24dp.png deleted file mode 100644 index 1e9294c12..000000000 Binary files a/java/com/android/incallui/res/drawable-hdpi/ic_block_grey600_24dp.png and /dev/null differ diff --git a/java/com/android/incallui/res/drawable-hdpi/ic_call_end_white_24dp.png b/java/com/android/incallui/res/drawable-hdpi/ic_call_end_white_24dp.png deleted file mode 100644 index 757d339c4..000000000 Binary files a/java/com/android/incallui/res/drawable-hdpi/ic_call_end_white_24dp.png and /dev/null differ diff --git a/java/com/android/incallui/res/drawable-hdpi/ic_close_grey600_24dp.png b/java/com/android/incallui/res/drawable-hdpi/ic_close_grey600_24dp.png deleted file mode 100644 index 9ab350e9a..000000000 Binary files a/java/com/android/incallui/res/drawable-hdpi/ic_close_grey600_24dp.png and /dev/null differ diff --git a/java/com/android/incallui/res/drawable-hdpi/ic_person_add_grey600_24dp.png b/java/com/android/incallui/res/drawable-hdpi/ic_person_add_grey600_24dp.png deleted file mode 100644 index 185d03393..000000000 Binary files a/java/com/android/incallui/res/drawable-hdpi/ic_person_add_grey600_24dp.png and /dev/null differ diff --git a/java/com/android/incallui/res/drawable-mdpi/ic_block_grey600_24dp.png b/java/com/android/incallui/res/drawable-mdpi/ic_block_grey600_24dp.png deleted file mode 100644 index edd666b73..000000000 Binary files a/java/com/android/incallui/res/drawable-mdpi/ic_block_grey600_24dp.png and /dev/null differ diff --git a/java/com/android/incallui/res/drawable-mdpi/ic_call_end_white_24dp.png b/java/com/android/incallui/res/drawable-mdpi/ic_call_end_white_24dp.png deleted file mode 100644 index 17eb4824e..000000000 Binary files a/java/com/android/incallui/res/drawable-mdpi/ic_call_end_white_24dp.png and /dev/null differ diff --git a/java/com/android/incallui/res/drawable-mdpi/ic_close_grey600_24dp.png b/java/com/android/incallui/res/drawable-mdpi/ic_close_grey600_24dp.png deleted file mode 100644 index 73faf52eb..000000000 Binary files a/java/com/android/incallui/res/drawable-mdpi/ic_close_grey600_24dp.png and /dev/null differ diff --git a/java/com/android/incallui/res/drawable-mdpi/ic_person_add_grey600_24dp.png b/java/com/android/incallui/res/drawable-mdpi/ic_person_add_grey600_24dp.png deleted file mode 100644 index ec3237086..000000000 Binary files a/java/com/android/incallui/res/drawable-mdpi/ic_person_add_grey600_24dp.png and /dev/null differ diff --git a/java/com/android/incallui/res/drawable-xhdpi/ic_block_grey600_24dp.png b/java/com/android/incallui/res/drawable-xhdpi/ic_block_grey600_24dp.png deleted file mode 100644 index 36210a8cb..000000000 Binary files a/java/com/android/incallui/res/drawable-xhdpi/ic_block_grey600_24dp.png and /dev/null differ diff --git a/java/com/android/incallui/res/drawable-xhdpi/ic_call_end_white_24dp.png b/java/com/android/incallui/res/drawable-xhdpi/ic_call_end_white_24dp.png deleted file mode 100644 index b00d82edd..000000000 Binary files a/java/com/android/incallui/res/drawable-xhdpi/ic_call_end_white_24dp.png and /dev/null differ diff --git a/java/com/android/incallui/res/drawable-xhdpi/ic_close_grey600_24dp.png b/java/com/android/incallui/res/drawable-xhdpi/ic_close_grey600_24dp.png deleted file mode 100644 index a3896c5c6..000000000 Binary files a/java/com/android/incallui/res/drawable-xhdpi/ic_close_grey600_24dp.png and /dev/null differ diff --git a/java/com/android/incallui/res/drawable-xhdpi/ic_person_add_grey600_24dp.png b/java/com/android/incallui/res/drawable-xhdpi/ic_person_add_grey600_24dp.png deleted file mode 100644 index e56481ed7..000000000 Binary files a/java/com/android/incallui/res/drawable-xhdpi/ic_person_add_grey600_24dp.png and /dev/null differ diff --git a/java/com/android/incallui/res/drawable-xxhdpi/ic_block_grey600_24dp.png b/java/com/android/incallui/res/drawable-xxhdpi/ic_block_grey600_24dp.png deleted file mode 100644 index 9f5120373..000000000 Binary files a/java/com/android/incallui/res/drawable-xxhdpi/ic_block_grey600_24dp.png and /dev/null differ diff --git a/java/com/android/incallui/res/drawable-xxhdpi/ic_call_end_white_24dp.png b/java/com/android/incallui/res/drawable-xxhdpi/ic_call_end_white_24dp.png deleted file mode 100644 index aeabe4a81..000000000 Binary files a/java/com/android/incallui/res/drawable-xxhdpi/ic_call_end_white_24dp.png and /dev/null differ diff --git a/java/com/android/incallui/res/drawable-xxhdpi/ic_close_grey600_24dp.png b/java/com/android/incallui/res/drawable-xxhdpi/ic_close_grey600_24dp.png deleted file mode 100644 index 22d7aa55e..000000000 Binary files a/java/com/android/incallui/res/drawable-xxhdpi/ic_close_grey600_24dp.png and /dev/null differ diff --git a/java/com/android/incallui/res/drawable-xxhdpi/ic_person_add_grey600_24dp.png b/java/com/android/incallui/res/drawable-xxhdpi/ic_person_add_grey600_24dp.png deleted file mode 100644 index c17dfe05f..000000000 Binary files a/java/com/android/incallui/res/drawable-xxhdpi/ic_person_add_grey600_24dp.png and /dev/null differ diff --git a/java/com/android/incallui/res/drawable-xxxhdpi/ic_block_grey600_24dp.png b/java/com/android/incallui/res/drawable-xxxhdpi/ic_block_grey600_24dp.png deleted file mode 100644 index 01df2b52b..000000000 Binary files a/java/com/android/incallui/res/drawable-xxxhdpi/ic_block_grey600_24dp.png and /dev/null differ diff --git a/java/com/android/incallui/res/drawable-xxxhdpi/ic_call_end_white_24dp.png b/java/com/android/incallui/res/drawable-xxxhdpi/ic_call_end_white_24dp.png deleted file mode 100644 index a6e8a7bc1..000000000 Binary files a/java/com/android/incallui/res/drawable-xxxhdpi/ic_call_end_white_24dp.png and /dev/null differ diff --git a/java/com/android/incallui/res/drawable-xxxhdpi/ic_close_grey600_24dp.png b/java/com/android/incallui/res/drawable-xxxhdpi/ic_close_grey600_24dp.png deleted file mode 100644 index 7d1c061f7..000000000 Binary files a/java/com/android/incallui/res/drawable-xxxhdpi/ic_close_grey600_24dp.png and /dev/null differ diff --git a/java/com/android/incallui/res/drawable-xxxhdpi/ic_person_add_grey600_24dp.png b/java/com/android/incallui/res/drawable-xxxhdpi/ic_person_add_grey600_24dp.png deleted file mode 100644 index e24919737..000000000 Binary files a/java/com/android/incallui/res/drawable-xxxhdpi/ic_person_add_grey600_24dp.png and /dev/null differ diff --git a/java/com/android/incallui/res/drawable/spam_notification_icon.xml b/java/com/android/incallui/res/drawable/spam_notification_icon.xml deleted file mode 100644 index a414428cb..000000000 --- a/java/com/android/incallui/res/drawable/spam_notification_icon.xml +++ /dev/null @@ -1,34 +0,0 @@ - - - - - - - - - - - - - - - - diff --git a/java/com/android/incallui/res/layout/caller_in_conference.xml b/java/com/android/incallui/res/layout/caller_in_conference.xml index 3a6773d20..4f4b2f043 100644 --- a/java/com/android/incallui/res/layout/caller_in_conference.xml +++ b/java/com/android/incallui/res/layout/caller_in_conference.xml @@ -113,7 +113,7 @@ android:clickable="true" android:contentDescription="@string/conference_caller_disconnect_content_description" android:scaleType="center" - android:src="@drawable/ic_call_end_white_24dp" + android:src="@drawable/quantum_ic_call_end_white_24" android:tint="@color/conference_call_manager_icon_color"/> diff --git a/java/com/android/incallui/res/values/colors.xml b/java/com/android/incallui/res/values/colors.xml index 0c73cdb10..5d97d729f 100644 --- a/java/com/android/incallui/res/values/colors.xml +++ b/java/com/android/incallui/res/values/colors.xml @@ -69,9 +69,6 @@ #841F10 - - @color/blocked_contact_background - #40000000 diff --git a/java/com/android/incallui/res/values/strings.xml b/java/com/android/incallui/res/values/strings.xml index 22c3c23cc..8d6940ed8 100644 --- a/java/com/android/incallui/res/values/strings.xml +++ b/java/com/android/incallui/res/values/strings.xml @@ -309,37 +309,6 @@ Closed now - - Know %1$s? - - Is %1$s spam? - - %1$s blocked and call was reported as spam. - - Call from %1$s reported as not spam. - - Tap to add to contacts or block spam number. - - This is the first time this number called you. If this call was spam, you can block this number and report it. - - Tap to report as NOT SPAM, or block it. - - We suspected this to be a spammer. If this call wasn\'t spam, tap "NOT SPAM" to report our mistake. - - Block & report - - Add contact - - Not spam - - Block number - - Add to contacts - - Block & report spam - - Not spam - No SIM or SIM error End call diff --git a/java/com/android/incallui/spam/AndroidManifest.xml b/java/com/android/incallui/spam/AndroidManifest.xml new file mode 100644 index 000000000..46319a6c1 --- /dev/null +++ b/java/com/android/incallui/spam/AndroidManifest.xml @@ -0,0 +1,41 @@ + + + + + + + + + + + + + diff --git a/java/com/android/incallui/spam/SpamCallListListener.java b/java/com/android/incallui/spam/SpamCallListListener.java index 997d4d6bc..f8bc9cebe 100644 --- a/java/com/android/incallui/spam/SpamCallListListener.java +++ b/java/com/android/incallui/spam/SpamCallListListener.java @@ -50,7 +50,6 @@ import com.android.dialer.notification.NotificationChannelId; import com.android.dialer.spam.Spam; import com.android.dialer.telecom.TelecomUtil; import com.android.dialer.util.PermissionsUtil; -import com.android.incallui.R; import com.android.incallui.call.CallList; import com.android.incallui.call.DialerCall; import com.android.incallui.call.DialerCall.CallHistoryStatus; @@ -90,7 +89,7 @@ public class SpamCallListListener implements CallList.Listener { /** Checks if the number is in the call history. */ @TargetApi(VERSION_CODES.M) - private final class NumberInCallHistoryWorker implements Worker { + private static final class NumberInCallHistoryWorker implements Worker { private final Context appContext; private final String number; @@ -262,7 +261,7 @@ public class SpamCallListListener implements CallList.Listener { .setCategory(Notification.CATEGORY_STATUS) .setPriority(Notification.PRIORITY_DEFAULT) .setColor(context.getColor(R.color.dialer_theme_color)) - .setSmallIcon(R.drawable.ic_call_end_white_24dp) + .setSmallIcon(R.drawable.quantum_ic_call_end_vd_theme_24) .setGroup(GROUP_KEY); if (BuildCompat.isAtLeastO()) { builder.setChannelId(NotificationChannelId.DEFAULT); @@ -289,7 +288,7 @@ public class SpamCallListListener implements CallList.Listener { // Add contact .addAction( new Notification.Action.Builder( - R.drawable.ic_person_add_grey600_24dp, + R.drawable.quantum_ic_person_add_vd_theme_24, context.getString(R.string.spam_notification_add_contact_action_text), createActivityPendingIntent( call, SpamNotificationActivity.ACTION_ADD_TO_CONTACTS)) @@ -297,7 +296,7 @@ public class SpamCallListListener implements CallList.Listener { // Block/report spam .addAction( new Notification.Action.Builder( - R.drawable.ic_block_grey600_24dp, + R.drawable.quantum_ic_block_vd_theme_24, context.getString(R.string.spam_notification_report_spam_action_text), createBlockReportSpamPendingIntent(call)) .build()) @@ -401,14 +400,14 @@ public class SpamCallListListener implements CallList.Listener { // Not spam .addAction( new Notification.Action.Builder( - R.drawable.ic_close_grey600_24dp, + R.drawable.quantum_ic_close_vd_theme_24, context.getString(R.string.spam_notification_not_spam_action_text), createNotSpamPendingIntent(call)) .build()) // Block/report spam .addAction( new Notification.Action.Builder( - R.drawable.ic_block_grey600_24dp, + R.drawable.quantum_ic_block_vd_theme_24, context.getString(R.string.spam_notification_block_spam_action_text), createBlockReportSpamPendingIntent(call)) .build()) diff --git a/java/com/android/incallui/spam/SpamNotificationActivity.java b/java/com/android/incallui/spam/SpamNotificationActivity.java index 160db2622..86988ad23 100644 --- a/java/com/android/incallui/spam/SpamNotificationActivity.java +++ b/java/com/android/incallui/spam/SpamNotificationActivity.java @@ -39,7 +39,6 @@ import com.android.dialer.logging.Logger; import com.android.dialer.logging.ReportingLocation; import com.android.dialer.notification.DialerNotificationManager; import com.android.dialer.spam.Spam; -import com.android.incallui.R; import com.android.incallui.call.DialerCall; /** Creates the after call notification dialogs. */ @@ -374,7 +373,7 @@ public class SpamNotificationActivity extends FragmentActivity { .setTitle(getString(R.string.spam_notification_title, getFormattedNumber(number))) .setMessage(getString(R.string.spam_notification_spam_call_expanded_text)) .setNeutralButton( - getString(R.string.notification_action_dismiss), + getString(R.string.spam_notification_action_dismiss), new DialogInterface.OnClickListener() { @Override public void onClick(DialogInterface dialog, int which) { @@ -460,7 +459,7 @@ public class SpamNotificationActivity extends FragmentActivity { .setCancelable(false) .setMessage(getString(R.string.spam_notification_non_spam_call_expanded_text)) .setNeutralButton( - getString(R.string.notification_action_dismiss), + getString(R.string.spam_notification_action_dismiss), new DialogInterface.OnClickListener() { @Override public void onClick(DialogInterface dialog, int which) { diff --git a/java/com/android/incallui/spam/res/drawable/spam_notification_icon.xml b/java/com/android/incallui/spam/res/drawable/spam_notification_icon.xml new file mode 100644 index 000000000..a414428cb --- /dev/null +++ b/java/com/android/incallui/spam/res/drawable/spam_notification_icon.xml @@ -0,0 +1,34 @@ + + + + + + + + + + + + + + + + diff --git a/java/com/android/incallui/spam/res/values/strings.xml b/java/com/android/incallui/spam/res/values/strings.xml new file mode 100644 index 000000000..02e7225a0 --- /dev/null +++ b/java/com/android/incallui/spam/res/values/strings.xml @@ -0,0 +1,54 @@ + + + + + + + Know %1$s? + + Is %1$s spam? + + %1$s blocked and call was reported as spam. + + Call from %1$s reported as not spam. + + Tap to add to contacts or block spam number. + + This is the first time this number called you. If this call was spam, you can block this number and report it. + + Tap to report as NOT SPAM, or block it. + + We suspected this to be a spammer. If this call wasn\'t spam, tap "NOT SPAM" to report our mistake. + + Block & report + + Add contact + + Not spam + + Block number + + Add to contacts + + Block & report spam + + Not spam + + + Decline + + -- cgit v1.2.3