From dd7a9f624953ff74edf8beab7903091097749080 Mon Sep 17 00:00:00 2001 From: twyen Date: Thu, 1 Feb 2018 12:34:41 -0800 Subject: Add suggestion reason ACCOUNT Bug: 72817785 Test: Unit tests PiperOrigin-RevId: 184178722 Change-Id: I7154058ab7ac1a94adc781a1aa9a49a3f13c1599 --- java/com/android/dialer/precall/impl/CallingAccountSelector.java | 2 +- java/com/android/dialer/preferredsim/suggestion/SuggestionProvider.java | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) (limited to 'java') diff --git a/java/com/android/dialer/precall/impl/CallingAccountSelector.java b/java/com/android/dialer/precall/impl/CallingAccountSelector.java index e92832947..8d7d75952 100644 --- a/java/com/android/dialer/precall/impl/CallingAccountSelector.java +++ b/java/com/android/dialer/precall/impl/CallingAccountSelector.java @@ -266,7 +266,7 @@ public class CallingAccountSelector implements PreCallAction { hints.add(context.getString(R.string.pre_call_select_phone_account_hint_frequent)); break; default: - throw Assert.createAssertionFailException("unexpected reason " + suggestion.reason); + LogUtil.w("CallingAccountSelector.buildHint", "unhandled reason " + suggestion.reason); } } return hints; diff --git a/java/com/android/dialer/preferredsim/suggestion/SuggestionProvider.java b/java/com/android/dialer/preferredsim/suggestion/SuggestionProvider.java index bb50889ec..abb6e980a 100644 --- a/java/com/android/dialer/preferredsim/suggestion/SuggestionProvider.java +++ b/java/com/android/dialer/preferredsim/suggestion/SuggestionProvider.java @@ -36,6 +36,8 @@ public interface SuggestionProvider { // The user has select the SIM for this category of calls (contacts from certain accounts, // etc.). USER_SET, + // The user has selected the SIM for all contacts on the account. + ACCOUNT, } /** The suggestion. */ -- cgit v1.2.3 From 974fc2903d4ecd0d8392a02b988982d24a2e93f4 Mon Sep 17 00:00:00 2001 From: Android Dialer Date: Thu, 1 Feb 2018 16:12:25 -0800 Subject: internal change Bug: 68825005 Test: Added unit tests on CallFeedbackListenerImpl, CallFeedbackNotificationManager and DialerCall. Also manually verified the change. PiperOrigin-RevId: 184211115 Change-Id: I50927036c3cd5d47862704376e2eef108c473fbf --- java/com/android/incallui/CallCardPresenter.java | 7 ------- java/com/android/incallui/InCallServiceImpl.java | 8 ++++++++ java/com/android/incallui/call/DialerCall.java | 12 +++++++++++- packages.mk | 1 + 4 files changed, 20 insertions(+), 8 deletions(-) (limited to 'java') diff --git a/java/com/android/incallui/CallCardPresenter.java b/java/com/android/incallui/CallCardPresenter.java index bdbbe8f7c..da5d1a8dd 100644 --- a/java/com/android/incallui/CallCardPresenter.java +++ b/java/com/android/incallui/CallCardPresenter.java @@ -48,7 +48,6 @@ import com.android.dialer.common.Assert; import com.android.dialer.common.LogUtil; import com.android.dialer.compat.ActivityCompat; import com.android.dialer.configprovider.ConfigProviderBindings; -import com.android.dialer.feedback.FeedbackComponent; import com.android.dialer.logging.DialerImpression; import com.android.dialer.logging.Logger; import com.android.dialer.multimedia.MultimediaData; @@ -154,11 +153,6 @@ public class CallCardPresenter return !TextUtils.isEmpty(call.getCallSubject()); } - private void addCallFeedbackListener(Context context) { - LogUtil.d("CallCardPresenter.addCallFeedbackListener", "Adding call feedback listener"); - CallList.getInstance().addListener(FeedbackComponent.get(context).getCallFeedbackListener()); - } - @Override public void onInCallScreenDelegateInit(InCallScreen inCallScreen) { Assert.isNotNull(inCallScreen); @@ -173,7 +167,6 @@ public class CallCardPresenter this.inCallScreen.showNoteSentToast(); } call.addListener(this); - addCallFeedbackListener(context); // start processing lookups right away. if (!call.isConferenceCall()) { startContactInfoSearch(call, true, call.getState() == DialerCall.State.INCOMING); diff --git a/java/com/android/incallui/InCallServiceImpl.java b/java/com/android/incallui/InCallServiceImpl.java index 539dba8dd..1cb6c478e 100644 --- a/java/com/android/incallui/InCallServiceImpl.java +++ b/java/com/android/incallui/InCallServiceImpl.java @@ -24,6 +24,7 @@ import android.telecom.Call; import android.telecom.CallAudioState; import android.telecom.InCallService; import com.android.dialer.blocking.FilteredNumberAsyncQueryHandler; +import com.android.dialer.feedback.FeedbackComponent; import com.android.incallui.audiomode.AudioModeProvider; import com.android.incallui.call.CallList; import com.android.incallui.call.ExternalCallList; @@ -39,6 +40,7 @@ public class InCallServiceImpl extends InCallService { private ReturnToCallController returnToCallController; private NewReturnToCallController newReturnToCallController; + private CallList.Listener feedbackListener; @Override public void onCallAudioStateChanged(CallAudioState audioState) { @@ -102,6 +104,8 @@ public class InCallServiceImpl extends InCallService { newReturnToCallController = new NewReturnToCallController(this, ContactInfoCache.getInstance(context)); } + feedbackListener = FeedbackComponent.get(context).getCallFeedbackListener(); + CallList.getInstance().addListener(feedbackListener); IBinder iBinder = super.onBind(intent); Trace.endSection(); @@ -134,6 +138,10 @@ public class InCallServiceImpl extends InCallService { newReturnToCallController.tearDown(); newReturnToCallController = null; } + if (feedbackListener != null) { + CallList.getInstance().removeListener(feedbackListener); + feedbackListener = null; + } Trace.endSection(); } } diff --git a/java/com/android/incallui/call/DialerCall.java b/java/com/android/incallui/call/DialerCall.java index e581ba3b0..1785eceb4 100644 --- a/java/com/android/incallui/call/DialerCall.java +++ b/java/com/android/incallui/call/DialerCall.java @@ -173,6 +173,8 @@ public class DialerCall implements VideoTechListener, StateChangedListener, Capa private List callCapableAccounts; private String countryIso; + private volatile boolean feedbackRequested = false; + public static String getNumberFromHandle(Uri handle) { return handle == null ? "" : handle.getSchemeSpecificPart(); } @@ -438,7 +440,7 @@ public class DialerCall implements VideoTechListener, StateChangedListener, Capa /* package-private */ Call getTelecomCall() { return telecomCall; } - + public StatusHints getStatusHints() { return telecomCall.getDetails().getStatusHints(); } @@ -1450,6 +1452,14 @@ public class DialerCall implements VideoTechListener, StateChangedListener, Capa return selectedAvailableVideoTechType; } + public void markFeedbackRequested() { + feedbackRequested = true; + } + + public boolean isFeedbackRequested() { + return feedbackRequested; + } + /** * Specifies whether a number is in the call history or not. {@link #CALL_HISTORY_STATUS_UNKNOWN} * means there is no result. diff --git a/packages.mk b/packages.mk index 40e4d02b7..70707225a 100644 --- a/packages.mk +++ b/packages.mk @@ -32,6 +32,7 @@ LOCAL_AAPT_FLAGS := \ com.android.dialer.databasepopulator \ com.android.dialer.dialpadview \ com.android.dialer.enrichedcall.simulator \ + com.android.dialer.feedback \ com.android.dialer.interactions \ com.android.dialer.lettertile \ com.android.dialer.location \ -- cgit v1.2.3