From 12da0b8101b77cbdbdd5754b667c4f122512b3c3 Mon Sep 17 00:00:00 2001 From: mdooley Date: Wed, 20 Sep 2017 11:40:30 -0700 Subject: Don't truncate long voicemail transcriptions Also repostion contact icon (for allen, is there a bug for that?) Originally i tried wrapping the transcription in a ScrollView, but that didn't really work since there's no easy way to set a max-height for it. Since most voicemails transcriptions are not that long, an easier solution was just to not limit the number of lines for the transcription. screen shots: https://drive.google.com/open?id=0B9o_KvtLkcuINkdXeVV0U0dOZVNfdExzSDNsai1Ld2F3ZlBN https://drive.google.com/open?id=0B9o_KvtLkcuIZTZFQzRQaW1nblBPN2JkVW1hMkR3YWl1b2JV Bug: 64211399 Test: manual PiperOrigin-RevId: 169425482 Change-Id: I63c9165f48d902c06e288280116cd9b95d67852c --- java/com/android/dialer/app/res/layout/call_log_list_item.xml | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) (limited to 'java/com/android') diff --git a/java/com/android/dialer/app/res/layout/call_log_list_item.xml b/java/com/android/dialer/app/res/layout/call_log_list_item.xml index 63f14db9d..39dcbacf5 100644 --- a/java/com/android/dialer/app/res/layout/call_log_list_item.xml +++ b/java/com/android/dialer/app/res/layout/call_log_list_item.xml @@ -63,6 +63,7 @@ + android:textIsSelectable="true"/> Date: Wed, 20 Sep 2017 11:42:17 -0700 Subject: Add more logging when video surface texture is destroyed. Bug: 63608380 Test: none PiperOrigin-RevId: 169425768 Change-Id: I297b945c9601bb070f3ef08d7ca34a76629b42c7 --- .../incallui/videosurface/impl/VideoSurfaceTextureImpl.java | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) (limited to 'java/com/android') diff --git a/java/com/android/incallui/videosurface/impl/VideoSurfaceTextureImpl.java b/java/com/android/incallui/videosurface/impl/VideoSurfaceTextureImpl.java index 6ce564a87..fa757247d 100644 --- a/java/com/android/incallui/videosurface/impl/VideoSurfaceTextureImpl.java +++ b/java/com/android/incallui/videosurface/impl/VideoSurfaceTextureImpl.java @@ -220,10 +220,10 @@ public class VideoSurfaceTextureImpl implements VideoSurfaceTexture { public boolean onSurfaceTextureDestroyed(SurfaceTexture destroyedSurfaceTexture) { LogUtil.i( "SurfaceTextureListener.onSurfaceTextureDestroyed", - "destroyedSurfaceTexture: " - + destroyedSurfaceTexture - + " " - + VideoSurfaceTextureImpl.this.toString()); + "destroyedSurfaceTexture: %s, %s, isDoneWithSurface: %b", + destroyedSurfaceTexture, + VideoSurfaceTextureImpl.this.toString(), + isDoneWithSurface); if (delegate != null) { delegate.onSurfaceDestroyed(VideoSurfaceTextureImpl.this); } else { -- cgit v1.2.3 From 2ea58f749187ec3360b7ce8acac632bece24929e Mon Sep 17 00:00:00 2001 From: calderwoodra Date: Wed, 20 Sep 2017 11:43:15 -0700 Subject: Fixed issue where all contacts weren't beign shown. The underlying issue was that if a query was input that filtered out all of the on device contacts, then the device rotated, the cursor would be reloaded with all contacts filtered and getCount == 0. This would cause the cursor to never be set in SearchCursorManager and on device contacts would no longer be shown because the cursor wasn't being saved. The reason this check was here, was because cursor headers were being managed by SearchCursorManager. Since headers were moved into the cursors we no longer need to set cursors to null if they are empty. Bug: 65859191 Test: existing PiperOrigin-RevId: 169425922 Change-Id: I0baf31c3747d679f394f3746f609b9487e52472d --- .../com/android/dialer/searchfragment/list/SearchCursorManager.java | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'java/com/android') diff --git a/java/com/android/dialer/searchfragment/list/SearchCursorManager.java b/java/com/android/dialer/searchfragment/list/SearchCursorManager.java index 95bede001..3704e817d 100644 --- a/java/com/android/dialer/searchfragment/list/SearchCursorManager.java +++ b/java/com/android/dialer/searchfragment/list/SearchCursorManager.java @@ -96,7 +96,7 @@ public final class SearchCursorManager { contactsCursor.close(); } - if (cursor != null && cursor.getCount() > 0) { + if (cursor != null) { contactsCursor = cursor; } else { contactsCursor = null; @@ -114,7 +114,7 @@ public final class SearchCursorManager { nearbyPlacesCursor.close(); } - if (cursor != null && cursor.getCount() > 0) { + if (cursor != null) { nearbyPlacesCursor = cursor; } else { nearbyPlacesCursor = null; @@ -132,7 +132,7 @@ public final class SearchCursorManager { corpDirectoryCursor.close(); } - if (cursor != null && cursor.getCount() > 0) { + if (cursor != null) { corpDirectoryCursor = cursor; } else { corpDirectoryCursor = null; -- cgit v1.2.3 From 95ef73e0b7ff185294c46a98acad9b5ba68f2984 Mon Sep 17 00:00:00 2001 From: Android Dialer Date: Wed, 20 Sep 2017 11:43:37 -0700 Subject: Forgot to keep this file in sync with //google/internal/communications/voicemailtranscription/v1/voicemail_transcription.proto Test: n/a PiperOrigin-RevId: 169425975 Change-Id: I0d53a576e1245cc1c4d7c8e36df3a510d8c7bdbe --- .../transcribe/grpc/voicemail_transcription.proto | 22 ++++++++++++++++++++++ 1 file changed, 22 insertions(+) (limited to 'java/com/android') diff --git a/java/com/android/voicemail/impl/transcribe/grpc/voicemail_transcription.proto b/java/com/android/voicemail/impl/transcribe/grpc/voicemail_transcription.proto index a2064d193..697e9e337 100644 --- a/java/com/android/voicemail/impl/transcribe/grpc/voicemail_transcription.proto +++ b/java/com/android/voicemail/impl/transcribe/grpc/voicemail_transcription.proto @@ -56,6 +56,18 @@ enum TranscriptionStatus { FAILED_NO_SPEECH_DETECTED = 7; } +// Enum that specifies the user's consent to donate a specific voicemail. +enum DonationPreference { + // Default but invalid value. + USER_PREFERENCE_UNSPECIFIED = 0; + + // User does not consent to donating this voicemail. + DO_NOT_DONATE = 1; + + // User consents to donating this voicemail. + DONATE = 2; +} + // Request for synchronous voicemail transcription. message TranscribeVoicemailRequest { // Voicemail audio file containing the raw bytes we receive from the carrier. @@ -78,6 +90,16 @@ message TranscribeVoicemailAsyncRequest { // Audio format of the voicemail file. optional AudioFormat audio_format = 2; + + // The client may provide their own unique ID for this transcription. It + // should be globally unique across all voicemails from all users. + // If the given transcription_id is not unique, an ALREADY_EXISTS (409) error + // will be returned. + // If no transcription_id is provided, one will be generated by the server. + optional string transcription_id = 3; + + // User's donation preference. + optional DonationPreference donation_preference = 4; } // Response for asynchronous voicemail transcription containing information -- cgit v1.2.3