From 37450d807ce5cd8df18acc72fb74b256fc8a58b1 Mon Sep 17 00:00:00 2001 From: yueg Date: Mon, 31 Jul 2017 15:34:51 -0700 Subject: Log bubble expansion and return to call. Test: BubbleTest PiperOrigin-RevId: 163758306 Change-Id: I391fe411822f01cf29075eab7cf42aeb676fd424 --- java/com/android/dialer/logging/dialer_impression.proto | 5 +++++ java/com/android/dialershared/bubble/Bubble.java | 4 ++++ 2 files changed, 9 insertions(+) (limited to 'java/com/android') diff --git a/java/com/android/dialer/logging/dialer_impression.proto b/java/com/android/dialer/logging/dialer_impression.proto index 8ccaf2dea..92ff0a675 100644 --- a/java/com/android/dialer/logging/dialer_impression.proto +++ b/java/com/android/dialer/logging/dialer_impression.proto @@ -478,5 +478,10 @@ message DialerImpression { // In in call UI UPGRADE_TO_VIDEO_CALL_BUTTON_SHOWN = 1236; + + // Bubble primary button first click to expand bubble + BUBBLE_PRIMARY_BUTTON_EXPAND = 1237; + // Bubble prinary button second click to return to call + BUBBLE_PRIMARY_BUTTON_RETURN_TO_CALL = 1238; } } diff --git a/java/com/android/dialershared/bubble/Bubble.java b/java/com/android/dialershared/bubble/Bubble.java index cbc64dd4e..9ce356a76 100644 --- a/java/com/android/dialershared/bubble/Bubble.java +++ b/java/com/android/dialershared/bubble/Bubble.java @@ -61,6 +61,8 @@ import android.widget.FrameLayout; import android.widget.ImageView; import android.widget.TextView; import android.widget.ViewAnimator; +import com.android.dialer.logging.DialerImpression; +import com.android.dialer.logging.Logger; import com.android.dialershared.bubble.BubbleInfo.Action; import java.lang.annotation.Retention; import java.lang.annotation.RetentionPolicy; @@ -418,6 +420,7 @@ public class Bubble { void primaryButtonClick() { if (expanded || textShowing || currentInfo.getActions().isEmpty()) { + Logger.get(context).logImpression(DialerImpression.Type.BUBBLE_PRIMARY_BUTTON_RETURN_TO_CALL); try { currentInfo.getPrimaryIntent().send(); } catch (CanceledException e) { @@ -426,6 +429,7 @@ public class Bubble { return; } + Logger.get(context).logImpression(DialerImpression.Type.BUBBLE_PRIMARY_BUTTON_EXPAND); doResize( () -> { onLeftRightSwitch(isDrawingFromRight()); -- cgit v1.2.3