From 7547d3e963dab2b1ef467ad27c3f0d25e150b50c Mon Sep 17 00:00:00 2001 From: Zachary Heidepriem Date: Mon, 6 Nov 2017 19:10:44 -0800 Subject: Move voicemail settings to dialer UI The voicemail module should not contain any UI code. Bug: 37258159 Test: DialerSettingsActivityTest,VoicemailSettingsFragmentTest. A future CL is refactoring VoicemailChangePinActivity into a fragment. PiperOrigin-RevId: 174125949 Change-Id: I89cf6a083b0a0952332440d76e7ae0cb1c801931 --- .../voicemail/stub/StubVoicemailClient.java | 36 ++++++++++++++-------- 1 file changed, 24 insertions(+), 12 deletions(-) (limited to 'java/com/android/voicemail/stub') diff --git a/java/com/android/voicemail/stub/StubVoicemailClient.java b/java/com/android/voicemail/stub/StubVoicemailClient.java index 4b8ed9ab8..0fe533e62 100644 --- a/java/com/android/voicemail/stub/StubVoicemailClient.java +++ b/java/com/android/voicemail/stub/StubVoicemailClient.java @@ -17,12 +17,12 @@ package com.android.voicemail.stub; import android.content.Context; -import android.content.Intent; import android.os.PersistableBundle; import android.support.annotation.NonNull; import android.support.annotation.Nullable; import android.telecom.PhoneAccountHandle; -import android.telephony.TelephonyManager; +import com.android.dialer.common.Assert; +import com.android.voicemail.PinChanger; import com.android.voicemail.VoicemailClient; import java.util.List; import javax.inject.Inject; @@ -56,11 +56,6 @@ public final class StubVoicemailClient implements VoicemailClient { public void appendOmtpVoicemailStatusSelectionClause( Context context, StringBuilder where, List selectionArgs) {} - @Override - public String getSettingsFragment() { - return null; - } - @Override public boolean isVoicemailArchiveEnabled(Context context, PhoneAccountHandle phoneAccountHandle) { return false; @@ -86,11 +81,8 @@ public final class StubVoicemailClient implements VoicemailClient { } @Override - public Intent getSetPinIntent(Context context, PhoneAccountHandle phoneAccountHandle) { - Intent intent = new Intent(TelephonyManager.ACTION_CONFIGURE_VOICEMAIL); - intent.putExtra(TelephonyManager.EXTRA_PHONE_ACCOUNT_HANDLE, phoneAccountHandle); - return intent; - } + public void setVoicemailDonationEnabled( + Context context, PhoneAccountHandle phoneAccountHandle, boolean enabled) {} @Override public boolean isActivated(Context context, PhoneAccountHandle phoneAccountHandle) { @@ -112,6 +104,26 @@ public final class StubVoicemailClient implements VoicemailClient { @Override public void onShutdown(@NonNull Context context) {} + @Override + public void addActivationStateListener(ActivationStateListener listener) { + throw Assert.createAssertionFailException("should never be called on stub."); + } + + @Override + public void removeActivationStateListener(ActivationStateListener listener) { + throw Assert.createAssertionFailException("should never be called on stub."); + } + + @Override + public boolean hasCarrierSupport(Context context, PhoneAccountHandle phoneAccountHandle) { + return false; + } + + @Override + public PinChanger createPinChanger(Context context, PhoneAccountHandle phoneAccountHandle) { + throw Assert.createAssertionFailException("should never be called on stub."); + } + @Override public void onTosAccepted(Context context) {} } -- cgit v1.2.3