From dcc84cd54ef6f8e4bbba59aadece397e4736ee09 Mon Sep 17 00:00:00 2001 From: erfanian Date: Tue, 17 Apr 2018 12:41:05 -0700 Subject: Add checks for call eligibility. Bug: 73736190,73775046 Test: none PiperOrigin-RevId: 193239591 Change-Id: I0af371b59e57a902df8162f3f04ba8e5a7900588 --- java/com/android/incallui/call/DialerCall.java | 13 +++- .../incallui/speakeasy/runtime/Constraints.java | 74 ++++++++++++++++++++++ 2 files changed, 85 insertions(+), 2 deletions(-) create mode 100644 java/com/android/incallui/speakeasy/runtime/Constraints.java (limited to 'java/com/android/incallui') diff --git a/java/com/android/incallui/call/DialerCall.java b/java/com/android/incallui/call/DialerCall.java index 5d32f46ad..2c1b5e74a 100644 --- a/java/com/android/incallui/call/DialerCall.java +++ b/java/com/android/incallui/call/DialerCall.java @@ -83,6 +83,7 @@ import com.android.dialer.theme.R; import com.android.dialer.util.PermissionsUtil; import com.android.incallui.audiomode.AudioModeProvider; import com.android.incallui.latencyreport.LatencyReport; +import com.android.incallui.speakeasy.runtime.Constraints; import com.android.incallui.videotech.VideoTech; import com.android.incallui.videotech.VideoTech.VideoTechListener; import com.android.incallui.videotech.duo.DuoVideoTech; @@ -1646,8 +1647,16 @@ public class DialerCall implements VideoTechListener, StateChangedListener, Capa /** Indicates the call is eligible for SpeakEasy */ public boolean isSpeakEasyEligible() { - // TODO(erfanian): refactor key location - return ConfigProviderBindings.get(context).getBoolean("speak_easy_enabled", false); + if (!Constraints.isAvailable(context)) { + return false; + } + + return !isPotentialEmergencyCallback() + && !isEmergencyCall() + && !isActiveRttCall() + && !isConferenceCall() + && !isVideoCall() + && !isVoiceMailNumber(); } /** Indicates the user has selected SpeakEasy */ diff --git a/java/com/android/incallui/speakeasy/runtime/Constraints.java b/java/com/android/incallui/speakeasy/runtime/Constraints.java new file mode 100644 index 000000000..1206d599c --- /dev/null +++ b/java/com/android/incallui/speakeasy/runtime/Constraints.java @@ -0,0 +1,74 @@ +/* + * Copyright (C) 2018 The Android Open Source Project + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License + */ + +package com.android.incallui.speakeasy.runtime; + +import android.annotation.TargetApi; +import android.content.Context; +import android.os.Build.VERSION_CODES; +import android.support.annotation.NonNull; +import android.support.annotation.VisibleForTesting; +import android.support.v4.os.BuildCompat; +import android.support.v4.os.UserManagerCompat; +import com.android.dialer.common.Assert; +import com.android.dialer.common.LogUtil; +import com.android.dialer.configprovider.ConfigProviderBindings; +import com.android.dialer.util.PermissionsUtil; + +/** Preconditions for the use of SpeakEasyModule */ +public final class Constraints { + + @VisibleForTesting public static final String SPEAK_EASY_ENABLED = "speak_easy_enabled"; + private static final String[] REQUIRED_PERMISSIONS = { + + }; + + // Non-instantiatable. + private Constraints() {} + + public static boolean isAvailable(@NonNull Context context) { + Assert.isNotNull(context); + + return isServerConfigEnabled(context) + && isUserUnlocked(context) + && meetsPlatformSdkFloor() + && hasNecessaryPermissions(context); + } + + private static boolean isServerConfigEnabled(@NonNull Context context) { + return ConfigProviderBindings.get(context).getBoolean(SPEAK_EASY_ENABLED, false); + } + + private static boolean isUserUnlocked(@NonNull Context context) { + return UserManagerCompat.isUserUnlocked(context); + } + + private static boolean meetsPlatformSdkFloor() { + return BuildCompat.isAtLeastP(); + } + + @SuppressWarnings("AndroidApiChecker") // Use of Java 8 APIs. + @TargetApi(VERSION_CODES.N) + private static boolean hasNecessaryPermissions(@NonNull Context context) { + for (String permission : REQUIRED_PERMISSIONS) { + if (!PermissionsUtil.hasPermission(context, permission)) { + LogUtil.i("Constraints.hasNecessaryPermissions", "missing permission: %s ", permission); + return false; + } + } + return true; + } +} -- cgit v1.2.3