From 32643ee1b0af99ae67dfd4641c4c163b699fe011 Mon Sep 17 00:00:00 2001 From: yueg Date: Wed, 28 Mar 2018 15:28:49 -0700 Subject: Remove unnecessary call to StatusBarNotifier.updateNotification(). The call for incoming call is covered in StatusBarNotifier.onStateChange(). The two calls in InCallActivity is not useful (maybe is before notification becoming foreground). Test: manual PiperOrigin-RevId: 190845157 Change-Id: I0f84f15cfda5294566fa8976e09aac5163f85aa9 --- java/com/android/incallui/InCallActivity.java | 3 --- java/com/android/incallui/InCallPresenter.java | 17 ----------------- 2 files changed, 20 deletions(-) (limited to 'java/com/android/incallui') diff --git a/java/com/android/incallui/InCallActivity.java b/java/com/android/incallui/InCallActivity.java index 8144ddb10..9d08dc4b6 100644 --- a/java/com/android/incallui/InCallActivity.java +++ b/java/com/android/incallui/InCallActivity.java @@ -476,7 +476,6 @@ public class InCallActivity extends TransactionSafeFragmentActivity if (!InCallPresenter.getInstance().isReadyForTearDown()) { updateTaskDescription(); - InCallPresenter.getInstance().updateNotification(); } // If there is a pending request to show or hide the dialpad, handle that now. @@ -534,8 +533,6 @@ public class InCallActivity extends TransactionSafeFragmentActivity dialpadFragment.onDialerKeyUp(null); } - InCallPresenter.getInstance().updateNotification(); - InCallPresenter.getInstance().getPseudoScreenState().removeListener(this); Trace.endSection(); } diff --git a/java/com/android/incallui/InCallPresenter.java b/java/com/android/incallui/InCallPresenter.java index a4b90f1a6..2e98a969d 100644 --- a/java/com/android/incallui/InCallPresenter.java +++ b/java/com/android/incallui/InCallPresenter.java @@ -1050,14 +1050,6 @@ public class InCallPresenter implements CallList.Listener, AudioModeProvider.Aud "updateIsChangingConfigurations = " + isChangingConfigurations); } - void updateNotification() { - // We need to update the notification bar when we leave the UI because that - // could trigger it to show again. - if (statusBarNotifier != null) { - statusBarNotifier.updateNotification(); - } - } - /** Called when the activity goes in/out of the foreground. */ public void onUiShowing(boolean showing) { if (proximitySensor != null) { @@ -1316,11 +1308,6 @@ public class InCallPresenter implements CallList.Listener, AudioModeProvider.Aud // know that start-up is complete. // // [ AND NOW YOU'RE IN THE CALL. voila! ] - // - // Our app is started using a fullScreen notification. We need to do this whenever - // we get an incoming call. Depending on the current context of the device, either a - // incoming call HUN or the actual InCallActivity will be shown. - final boolean startIncomingCallSequence = (InCallState.INCOMING == newState); // A dialog to show on top of the InCallUI to select a PhoneAccount final boolean showAccountPicker = (InCallState.WAITING_FOR_ACCOUNT == newState); @@ -1387,10 +1374,6 @@ public class InCallPresenter implements CallList.Listener, AudioModeProvider.Aud if (showCallUi || showAccountPicker) { LogUtil.i("InCallPresenter.startOrFinishUi", "Start in call UI"); showInCall(false /* showDialpad */, !showAccountPicker /* newOutgoingCall */); - } else if (startIncomingCallSequence) { - LogUtil.i("InCallPresenter.startOrFinishUi", "Start Full Screen in call UI"); - - statusBarNotifier.updateNotification(); } else if (newState == InCallState.NO_CALLS) { // The new state is the no calls state. Tear everything down. attemptFinishActivity(); -- cgit v1.2.3