From c4aea8f66c3e9e6bf30426d17ff097d2acd1fdef Mon Sep 17 00:00:00 2001
From: maxwelb <maxwelb@google.com>
Date: Wed, 28 Feb 2018 14:29:07 -0800
Subject: Update voicemail donations strings

Bug: 73798533
Test: Manual :/
PiperOrigin-RevId: 187383740
Change-Id: I0f35ccbf19a59b35338cb144f0192b692585159f
---
 .../android/dialer/app/calllog/PhoneCallDetailsHelper.java |  8 +++-----
 java/com/android/dialer/app/res/values/strings.xml         | 14 +++++---------
 .../dialer/voicemail/settings/res/values/strings.xml       |  2 +-
 3 files changed, 9 insertions(+), 15 deletions(-)

(limited to 'java/com/android/dialer')

diff --git a/java/com/android/dialer/app/calllog/PhoneCallDetailsHelper.java b/java/com/android/dialer/app/calllog/PhoneCallDetailsHelper.java
index 82c98156b..1f27e5b69 100644
--- a/java/com/android/dialer/app/calllog/PhoneCallDetailsHelper.java
+++ b/java/com/android/dialer/app/calllog/PhoneCallDetailsHelper.java
@@ -329,10 +329,8 @@ public class PhoneCallDetailsHelper
 
     // Use a custom title to prevent truncation, sigh
     TextView title = new TextView(context);
-    title.setText(
-        ratingValue == TranscriptionRatingValue.GOOD_TRANSCRIPTION
-            ? R.string.voicemail_donation_promo_good_title
-            : R.string.voicemail_donation_promo_bad_title);
+    title.setText(R.string.voicemail_donation_promo_title);
+
     title.setTypeface(Typeface.create("sans-serif-medium", Typeface.NORMAL));
     title.setTextSize(TypedValue.COMPLEX_UNIT_SP, 20);
     title.setTextColor(ContextCompat.getColor(context, R.color.dialer_primary_text_color));
@@ -383,7 +381,7 @@ public class PhoneCallDetailsHelper
     CharSequence content = context.getString(R.string.voicemail_donation_promo_content);
     CharSequence learnMore = context.getString(R.string.voicemail_donation_promo_learn_more);
     String learnMoreUrl = context.getString(R.string.voicemail_donation_promo_learn_more_url);
-    SpannableString span = new SpannableString(content + "\n" + learnMore);
+    SpannableString span = new SpannableString(content + " " + learnMore);
     int end = span.length();
     int start = end - learnMore.length();
     span.setSpan(new URLSpan(learnMoreUrl), start, end, Spanned.SPAN_EXCLUSIVE_EXCLUSIVE);
diff --git a/java/com/android/dialer/app/res/values/strings.xml b/java/com/android/dialer/app/res/values/strings.xml
index 5773a0cd7..5974f47fd 100644
--- a/java/com/android/dialer/app/res/values/strings.xml
+++ b/java/com/android/dialer/app/res/values/strings.xml
@@ -675,19 +675,15 @@
        [CHAR LIMIT=64] -->
   <string name="voicemail_transcription_failed_no_speech">Transcript not available. No speech detected.</string>
 
-  <!-- Title of voicemail donation promo dialog, show after clicking a 'thumbs up' rating icon
-       [CHAR LIMIT=64] -->
-  <string name="voicemail_donation_promo_good_title">Thanks! Would you like to help us improve transcriptions?</string>
-
-  <!-- Title of voicemail donation promo dialog, show after clicking a 'thumbs up' rating icon
-       [CHAR LIMIT=64] -->
-  <string name="voicemail_donation_promo_bad_title">Sorry. Would you like to help us improve transcriptions?</string>
+  <!-- Title of voicemail donation promo dialog
+      [CHAR LIMIT=64] -->
+  <string name="voicemail_donation_promo_title">Help improve transcription accuracy?</string>
 
   <!-- Content of voicemail donation promo dialog
        [CHAR LIMIT=NONE] -->
   <string name="voicemail_donation_promo_content">
-    Let Google review your voicemail messages to improve transcription quality.
-    For voicemail transcription analysis, your voicemail messages are stored anonymously.
+    Let Google review this and future voicemail messages with transcripts.
+    They\'ll be stored anonymously. Change Settings any time.
   </string>
 
   <!-- Text for a 'learn more' link at the end of the voicemail donation promo dialog content -->
diff --git a/java/com/android/dialer/voicemail/settings/res/values/strings.xml b/java/com/android/dialer/voicemail/settings/res/values/strings.xml
index 47228b70b..3056ef6b2 100644
--- a/java/com/android/dialer/voicemail/settings/res/values/strings.xml
+++ b/java/com/android/dialer/voicemail/settings/res/values/strings.xml
@@ -116,7 +116,7 @@
        [CHAR LIMIT=NONE] -->
   <string name="voicemail_donate_preference_summary_not_activated">Visual voicemail is not activated yet, please try again later</string>
   <!-- Summary information for visual voicemail donation setting [CHAR LIMIT=NONE] -->
-  <string name="voicemail_donate_preference_summary_info">Let Google review your voicemail messages to improve transcription quality</string>
+  <string name="voicemail_donate_preference_summary_info">Let Google review your voicemail messages to improve transcription accuracy</string>
 
   <!-- Title for disable visual voicemail confirmation dialog [CHAR LIMIT=40] -->
   <string name="confirm_disable_voicemail_dialog_title">Turn off visual voicemail</string>
-- 
cgit v1.2.3