From 039fc5fdfdca26aa2edcb38be45362a98110f4c8 Mon Sep 17 00:00:00 2001 From: calderwoodra Date: Tue, 8 Aug 2017 00:31:05 -0700 Subject: New Search Fragment no longer crashes when the device is rotated. In the new search fragment, if you rotated the device, a crash would occur because we were prematurly closing the cursors on our own. Since the cursors are managed by CursorLoaders, we don't actually need to close the cursors ourselves and can leave that to the framework. Bug: 37209462 Test: SearchFragmentIntegrationTest PiperOrigin-RevId: 164562508 Change-Id: Id33274ccb23d026dab352e754a5f03ab834d9d14 --- java/com/android/dialer/searchfragment/list/NewSearchFragment.java | 3 --- .../android/dialer/searchfragment/list/res/layout/fragment_search.xml | 2 +- 2 files changed, 1 insertion(+), 4 deletions(-) (limited to 'java/com/android/dialer') diff --git a/java/com/android/dialer/searchfragment/list/NewSearchFragment.java b/java/com/android/dialer/searchfragment/list/NewSearchFragment.java index dff6c7282..70358bb16 100644 --- a/java/com/android/dialer/searchfragment/list/NewSearchFragment.java +++ b/java/com/android/dialer/searchfragment/list/NewSearchFragment.java @@ -152,9 +152,6 @@ public final class NewSearchFragment extends Fragment @Override public void onDestroy() { super.onDestroy(); - // close adapters - adapter.setNearbyPlacesCursor(null); - adapter.setContactsCursor(null); ThreadUtil.getUiThreadHandler().removeCallbacks(loadNearbyPlacesRunnable); } diff --git a/java/com/android/dialer/searchfragment/list/res/layout/fragment_search.xml b/java/com/android/dialer/searchfragment/list/res/layout/fragment_search.xml index 06c266082..07113c044 100644 --- a/java/com/android/dialer/searchfragment/list/res/layout/fragment_search.xml +++ b/java/com/android/dialer/searchfragment/list/res/layout/fragment_search.xml @@ -16,7 +16,7 @@ -->