From 3eb6fd18fe64c02f0433de75bec7cfca9d231e62 Mon Sep 17 00:00:00 2001
From: calderwoodra <calderwoodra@google.com>
Date: Tue, 1 May 2018 11:01:37 -0700
Subject: Fixed speed dial remove.

App would crash when users attempted to remove a starred contact because we try
to update Phone.CONTENT_URI, which is not allowed. Test assumed that
we could update PHone.CONTENT_URI, which is why this wasn't caught.

Updated the test to verify the contact in Contacts.CONTENT_URI get updated to
starred = 0. Unforunately, since fakeContentProvider doesn't work exactly like
cp2, the update won't propogate to Phone.CONTENT_URI, so out test is less than
ideal, but it should cover our bases.

Also updated the image and text for starring a suggestion.

Bug: 78923466
Test: tap
PiperOrigin-RevId: 194962080
Change-Id: I9f8f71d70ba83510682890917081380a3c51cd7a
---
 java/com/android/dialer/speeddial/res/values/strings.xml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

(limited to 'java/com/android/dialer/speeddial/res/values/strings.xml')

diff --git a/java/com/android/dialer/speeddial/res/values/strings.xml b/java/com/android/dialer/speeddial/res/values/strings.xml
index 028f6a90c..d2f5371b8 100644
--- a/java/com/android/dialer/speeddial/res/values/strings.xml
+++ b/java/com/android/dialer/speeddial/res/values/strings.xml
@@ -57,5 +57,5 @@
   <string name="contact_menu_contact_info">Contact info</string>
 
   <!-- Text shown to the user in a button to prompt them to mark a contact as a favorite contact [CHAR LIMIT=30]. -->
-  <string name="suggested_contact_bottom_sheet_add_favorite_option">Add to favorites</string>
+  <string name="suggested_contact_bottom_sheet_add_favorite_option">Add favorite</string>
 </resources>
\ No newline at end of file
-- 
cgit v1.2.3