From b3bd5f5c9687feaa795dc630a88790ccf6e7e99e Mon Sep 17 00:00:00 2001 From: calderwoodra Date: Wed, 2 May 2018 15:26:04 -0700 Subject: Tuned Speed Dial UI according to red lines. Bug: 78490736 Test: manual PiperOrigin-RevId: 195161904 Change-Id: I7d3600267223fcfafae42f3f52bfd6cfff8b9146 --- .../android/dialer/speeddial/DisambigDialog.java | 32 ++++++++++++++++++++-- 1 file changed, 29 insertions(+), 3 deletions(-) (limited to 'java/com/android/dialer/speeddial/DisambigDialog.java') diff --git a/java/com/android/dialer/speeddial/DisambigDialog.java b/java/com/android/dialer/speeddial/DisambigDialog.java index 0d29a9c84..6b6ab26f5 100644 --- a/java/com/android/dialer/speeddial/DisambigDialog.java +++ b/java/com/android/dialer/speeddial/DisambigDialog.java @@ -25,12 +25,14 @@ import android.support.annotation.WorkerThread; import android.support.v4.app.DialogFragment; import android.support.v4.app.FragmentManager; import android.support.v7.app.AlertDialog; +import android.text.TextUtils; import android.util.ArraySet; import android.view.LayoutInflater; import android.view.View; import android.widget.CheckBox; import android.widget.ImageView; import android.widget.LinearLayout; +import android.widget.LinearLayout.LayoutParams; import android.widget.TextView; import com.android.dialer.callintent.CallInitiationType; import com.android.dialer.callintent.CallIntentBuilder; @@ -84,6 +86,16 @@ public class DisambigDialog extends DialogFragment { return new AlertDialog.Builder(getActivity()).setView(view).create(); } + @Override + public void onResume() { + super.onResume(); + getDialog() + .getWindow() + .setLayout( + getContext().getResources().getDimensionPixelSize(R.dimen.disambig_dialog_width), + LayoutParams.WRAP_CONTENT); + } + @Override public void onPause() { super.onPause(); @@ -105,19 +117,33 @@ public class DisambigDialog extends DialogFragment { for (Channel channel : channels) { // TODO(calderwoodra): use fuzzy number matcher if (phoneNumbers.add(channel.number())) { + if (phoneNumbers.size() != 1) { + insertDivider(container); + } insertHeader(container, channel.number(), channel.label()); } insertOption(container, channel); } } - private void insertHeader(LinearLayout container, String number, String phoneType) { + private void insertDivider(LinearLayout container) { + View view = + getActivity() + .getLayoutInflater() + .inflate(R.layout.disambig_dialog_divider, container, false); + container.addView(view); + } + + private void insertHeader(LinearLayout container, String number, String label) { View view = getActivity() .getLayoutInflater() .inflate(R.layout.disambig_option_header_layout, container, false); - ((TextView) view.findViewById(R.id.disambig_header_phone_type)).setText(phoneType); - ((TextView) view.findViewById(R.id.disambig_header_phone_number)).setText(number); + String secondaryInfo = + TextUtils.isEmpty(label) + ? number + : getContext().getString(R.string.call_subject_type_and_number, label, number); + ((TextView) view.findViewById(R.id.disambig_header_phone_label)).setText(secondaryInfo); container.addView(view); } -- cgit v1.2.3