From 9709446856e01c23cfd02f83f85ecd79bdd8f785 Mon Sep 17 00:00:00 2001 From: weijiaxu Date: Wed, 20 Dec 2017 18:44:55 -0800 Subject: Quick fix for bugs on simulator voice call. -Fix incoming spam call which doesn't respond to UI interaction. Reason for that was connectionTag didn't get assigned. -Fix dialog of custom incoming/outgoing call. Current value of callerIdPresentationChoice is 0 which leads dialer to show UNKNOWN number on InCallUiActivity. Set callerIdPresentationChoice to 1 (ALLOWED) as default value. Test: on a local device. PiperOrigin-RevId: 179760724 Change-Id: I68f6e238ecd78a017d6539b25f95645c72e2cd0f --- java/com/android/dialer/simulator/impl/SimulatorDialogFragment.java | 3 ++- java/com/android/dialer/simulator/impl/SimulatorVoiceCall.java | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) (limited to 'java/com/android/dialer/simulator') diff --git a/java/com/android/dialer/simulator/impl/SimulatorDialogFragment.java b/java/com/android/dialer/simulator/impl/SimulatorDialogFragment.java index f8403c7fe..96ea62739 100644 --- a/java/com/android/dialer/simulator/impl/SimulatorDialogFragment.java +++ b/java/com/android/dialer/simulator/impl/SimulatorDialogFragment.java @@ -29,7 +29,7 @@ public final class SimulatorDialogFragment extends DialogFragment { private final String[] callerIdPresentationItems = { "ALLOWED", "PAYPHONE", "RESTRICTED", "UNKNOWN" }; - private int callerIdPresentationChoice; + private int callerIdPresentationChoice = 1; private DialogCallback dialogCallback; @@ -47,6 +47,7 @@ public final class SimulatorDialogFragment extends DialogFragment { public Dialog onCreateDialog(Bundle bundle) { AlertDialog.Builder builder = new AlertDialog.Builder(getActivity()); final EditText input = new EditText(getActivity()); + input.setHint("Please input phone number"); builder .setTitle("Phone Number:") .setView(input) diff --git a/java/com/android/dialer/simulator/impl/SimulatorVoiceCall.java b/java/com/android/dialer/simulator/impl/SimulatorVoiceCall.java index 89c5d2f14..ff00dd87e 100644 --- a/java/com/android/dialer/simulator/impl/SimulatorVoiceCall.java +++ b/java/com/android/dialer/simulator/impl/SimulatorVoiceCall.java @@ -120,7 +120,8 @@ final class SimulatorVoiceCall private void addSpamIncomingCall() { String callerId = "+1-661-778-3020"; /* Blacklisted custom spam number */ - SimulatorSimCallManager.addNewIncomingCall(context, callerId, false /* isVideo */); + connectionTag = + SimulatorSimCallManager.addNewIncomingCall(context, callerId, false /* isVideo */); } private void addNewEmergencyCallBack() { -- cgit v1.2.3