From 76cf7e18da00545145df8a5f215f3a377d605866 Mon Sep 17 00:00:00 2001 From: calderwoodra Date: Wed, 28 Feb 2018 17:10:18 -0800 Subject: Some small bug fixes in NUI. - Never show the dialpad chooser in MainActivity. - If the call log changed while dialer was in the background, it would trigger the content observer to fetch the new info, which would request it's parent that wasn't there. Now we register/unregister them in onResume/onPause. This is safe to do because we force refresh the data onResume anyways, so any changes will still be shown. Bug: 73972084,73975555,73995512 Test: manual PiperOrigin-RevId: 187407058 Change-Id: Iae86dabbcb852398bb2b9df4627e234261ab8030 --- java/com/android/dialer/dialpadview/DialpadFragment.java | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) (limited to 'java/com/android/dialer/dialpadview') diff --git a/java/com/android/dialer/dialpadview/DialpadFragment.java b/java/com/android/dialer/dialpadview/DialpadFragment.java index 680159057..f09333280 100644 --- a/java/com/android/dialer/dialpadview/DialpadFragment.java +++ b/java/com/android/dialer/dialpadview/DialpadFragment.java @@ -1312,7 +1312,9 @@ public class DialpadFragment extends Fragment * or ringing or dialing, or on hold). */ private boolean isPhoneInUse() { - return getContext() != null && TelecomUtil.isInManagedCall(getContext()); + return getContext() != null + && TelecomUtil.isInManagedCall(getContext()) + && FragmentUtils.getParentUnsafe(this, HostInterface.class).shouldShowDialpadChooser(); } /** @return true if the phone is a CDMA phone type */ @@ -1584,6 +1586,9 @@ public class DialpadFragment extends Fragment * unless there happens to be content showing. */ boolean onDialpadSpacerTouchWithEmptyQuery(); + + /** Returns true if this fragment's parent want the dialpad to show the dialpad chooser. */ + boolean shouldShowDialpadChooser(); } /** -- cgit v1.2.3