From 26f520249eccdcf2352806ba8d6a54bb8e5045a6 Mon Sep 17 00:00:00 2001 From: zachh Date: Fri, 26 Jan 2018 16:28:44 -0800 Subject: Reworked the internals of DialerPhoneNumber. It turns out the storing the libphonenumber representation of the number is not particularly useful because even formatting these objects cannot be done on the main thread. Rather than propagate the requirement of using PhoneNumberUtil (and background threads by extension) in the call log UI, we now just store a dialer-normalized version of the number which contains all information required by the UI in a way that allows us to avoid any background work in the UI code. Bug: 72563861 Test: existing PiperOrigin-RevId: 183463907 Change-Id: I4bdadaccb7a84033b3c72c54fe3833064f587ee3 --- java/com/android/dialer/calllog/ui/menu/Modules.java | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) (limited to 'java/com/android/dialer/calllog/ui/menu/Modules.java') diff --git a/java/com/android/dialer/calllog/ui/menu/Modules.java b/java/com/android/dialer/calllog/ui/menu/Modules.java index 96e5951c6..d59155810 100644 --- a/java/com/android/dialer/calllog/ui/menu/Modules.java +++ b/java/com/android/dialer/calllog/ui/menu/Modules.java @@ -46,8 +46,7 @@ final class Modules { // Conditionally add each module, which are items in the bottom sheet's menu. List modules = new ArrayList<>(); - // TODO(zach): Don't use raw input. - String normalizedNumber = row.number().getRawInput().getNumber(); + String normalizedNumber = row.number().getNormalizedNumber(); boolean canPlaceCalls = PhoneNumberHelper.canPlaceCallsTo(normalizedNumber, row.numberPresentation()); @@ -138,8 +137,7 @@ final class Modules { .build(); } - // TODO(zachh): Don't use raw input. - String normalizedNumber = row.number().getRawInput().getNumber(); + String normalizedNumber = row.number().getNormalizedNumber(); DialerContact.Builder dialerContactBuilder = DialerContact.newBuilder() .setNumber(normalizedNumber) -- cgit v1.2.3