From 938468da6f5c225ebb161a68bd949c9cf3261892 Mon Sep 17 00:00:00 2001 From: Eric Erfanian Date: Tue, 24 Oct 2017 14:05:52 -0700 Subject: Rename the new bubble package name from "bubble" to "newbubble". It fixes AOSP for package name conflict. Test: manual PiperOrigin-RevId: 173298696 Change-Id: Id10ebe0bcf029e61f65cf6580c7198abd8395081 --- java/com/android/dialer/callcomposer/CallComposerActivity.java | 2 +- java/com/android/dialer/callcomposer/GalleryComposerFragment.java | 4 ++-- java/com/android/dialer/callcomposer/camera/CameraPreview.java | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) (limited to 'java/com/android/dialer/callcomposer') diff --git a/java/com/android/dialer/callcomposer/CallComposerActivity.java b/java/com/android/dialer/callcomposer/CallComposerActivity.java index 83fe2d9de..60826fd5d 100644 --- a/java/com/android/dialer/callcomposer/CallComposerActivity.java +++ b/java/com/android/dialer/callcomposer/CallComposerActivity.java @@ -242,7 +242,7 @@ public class CallComposerActivity extends AppCompatActivity } private void onCopyAndResizeImageFailure(Throwable throwable) { - // TODO(b/34279096) - gracefully handle message failure + // TODO(a bug) - gracefully handle message failure LogUtil.e("CallComposerActivity.onCopyAndResizeImageFailure", "copy Failed", throwable); } diff --git a/java/com/android/dialer/callcomposer/GalleryComposerFragment.java b/java/com/android/dialer/callcomposer/GalleryComposerFragment.java index 01e067440..2e6a28c33 100644 --- a/java/com/android/dialer/callcomposer/GalleryComposerFragment.java +++ b/java/com/android/dialer/callcomposer/GalleryComposerFragment.java @@ -137,7 +137,7 @@ public class GalleryComposerFragment extends CallComposerFragment }) .onFailure( throwable -> { - // TODO(b/34279096) - gracefully handle message failure + // TODO(a bug) - gracefully handle message failure LogUtil.e( "GalleryComposerFragment.onFailure", "data preparation failed", throwable); }) @@ -303,7 +303,7 @@ public class GalleryComposerFragment extends CallComposerFragment if (url != null) { copyAndResizeImage.executeParallel(Uri.parse(url)); } else { - // TODO(b/34279096) - gracefully handle message failure + // TODO(a bug) - gracefully handle message failure } } } diff --git a/java/com/android/dialer/callcomposer/camera/CameraPreview.java b/java/com/android/dialer/callcomposer/camera/CameraPreview.java index 6581ad67b..eaea78961 100644 --- a/java/com/android/dialer/callcomposer/camera/CameraPreview.java +++ b/java/com/android/dialer/callcomposer/camera/CameraPreview.java @@ -65,7 +65,7 @@ public class CameraPreview { } // Opening camera is very expensive. Most of the ANR reports seem to be related to the camera. - // So we delay until the camera is actually needed. See b/23287938 + // So we delay until the camera is actually needed. See a bug private void maybeOpenCamera() { boolean visible = mHost.getView().getVisibility() == View.VISIBLE; if (mTabHasBeenShown && visible && PermissionsUtil.hasCameraPermissions(getContext())) { -- cgit v1.2.3