From 999b5d5a7152c3b7608fe30630b983512e9e4e43 Mon Sep 17 00:00:00 2001 From: linyuh Date: Wed, 28 Feb 2018 16:47:17 -0800 Subject: Log contact source when reporting spam from the new UI. Bug: 73780748 Test: PhoneLookupInfoConsolidatorTest PiperOrigin-RevId: 187404074 Change-Id: I1db81304909fbf63aba00088c12e18922042c3b1 --- .../dialer/blockreportspam/ShowBlockReportSpamDialogReceiver.java | 5 ++--- .../dialer/blockreportspam/block_report_spam_dialog_info.proto | 6 +++++- 2 files changed, 7 insertions(+), 4 deletions(-) (limited to 'java/com/android/dialer/blockreportspam') diff --git a/java/com/android/dialer/blockreportspam/ShowBlockReportSpamDialogReceiver.java b/java/com/android/dialer/blockreportspam/ShowBlockReportSpamDialogReceiver.java index 364736efd..f24bb1c06 100644 --- a/java/com/android/dialer/blockreportspam/ShowBlockReportSpamDialogReceiver.java +++ b/java/com/android/dialer/blockreportspam/ShowBlockReportSpamDialogReceiver.java @@ -26,7 +26,6 @@ import com.android.dialer.blockreportspam.BlockReportSpamDialogs.OnConfirmListen import com.android.dialer.blockreportspam.BlockReportSpamDialogs.OnSpamDialogClickListener; import com.android.dialer.common.Assert; import com.android.dialer.common.LogUtil; -import com.android.dialer.logging.ContactSource; import com.android.dialer.logging.DialerImpression; import com.android.dialer.logging.Logger; import com.android.dialer.protos.ProtoParsers; @@ -109,7 +108,7 @@ public final class ShowBlockReportSpamDialogReceiver extends BroadcastReceiver { dialogInfo.getCountryIso(), dialogInfo.getCallType(), dialogInfo.getReportingLocation(), - ContactSource.Type.UNKNOWN_SOURCE_TYPE /* TODO(a bug): Fix. */); + dialogInfo.getContactSource()); } // TODO(a bug): Block the number. @@ -154,7 +153,7 @@ public final class ShowBlockReportSpamDialogReceiver extends BroadcastReceiver { dialogInfo.getCountryIso(), dialogInfo.getCallType(), dialogInfo.getReportingLocation(), - ContactSource.Type.UNKNOWN_SOURCE_TYPE /* TODO(a bug): Fix. */); + dialogInfo.getContactSource()); } }; diff --git a/java/com/android/dialer/blockreportspam/block_report_spam_dialog_info.proto b/java/com/android/dialer/blockreportspam/block_report_spam_dialog_info.proto index 3c5a61652..70872c7e0 100644 --- a/java/com/android/dialer/blockreportspam/block_report_spam_dialog_info.proto +++ b/java/com/android/dialer/blockreportspam/block_report_spam_dialog_info.proto @@ -7,11 +7,12 @@ option optimize_for = LITE_RUNTIME; package com.android.dialer.blockreportspam; +import "java/com/android/dialer/logging/contact_source.proto"; import "java/com/android/dialer/logging/reporting_location.proto"; // Contains information needed in dialogs that allow a user to block a number // and/or report it as spam/not spam. -// Next ID: 5 +// Next ID: 6 message BlockReportSpamDialogInfo { // A dialer-normalized version of the number used in the dialogs. // See DialerPhoneNumber#normalized_number. @@ -27,4 +28,7 @@ message BlockReportSpamDialogInfo { // The location where the number is reported. optional com.android.dialer.logging.ReportingLocation.Type reporting_location = 4; + + // The source where contact info is associated with the number. + optional com.android.dialer.logging.ContactSource.Type contact_source = 5; } \ No newline at end of file -- cgit v1.2.3