From dde01c59422e1316fc51e53337e1a21dd2ffa480 Mon Sep 17 00:00:00 2001 From: twyen Date: Fri, 22 Sep 2017 10:07:31 -0700 Subject: Log non-contact lightbringer actions video call upgrade and calling from call log is logged Bug: 66222115 Test: DialerCallTest, GoogleCallLogAdapterTest PiperOrigin-RevId: 169703001 Change-Id: Ib4dc3507dec09f49d41cec09d32cc9800477ee8b --- .../dialer/app/calllog/CallLogListItemViewHolder.java | 13 +++++++++++++ 1 file changed, 13 insertions(+) (limited to 'java/com/android/dialer/app') diff --git a/java/com/android/dialer/app/calllog/CallLogListItemViewHolder.java b/java/com/android/dialer/app/calllog/CallLogListItemViewHolder.java index 301d89576..60acb55fc 100644 --- a/java/com/android/dialer/app/calllog/CallLogListItemViewHolder.java +++ b/java/com/android/dialer/app/calllog/CallLogListItemViewHolder.java @@ -80,6 +80,7 @@ import com.android.dialer.lettertile.LetterTileDrawable.ContactType; import com.android.dialer.lightbringer.Lightbringer; import com.android.dialer.lightbringer.LightbringerComponent; import com.android.dialer.logging.ContactSource; +import com.android.dialer.logging.ContactSource.Type; import com.android.dialer.logging.DialerImpression; import com.android.dialer.logging.InteractionEvent; import com.android.dialer.logging.Logger; @@ -925,6 +926,11 @@ public final class CallLogListItemViewHolder extends RecyclerView.ViewHolder if (packageName != null && packageName.equals(getLightbringer().getPackageName())) { Logger.get(mContext) .logImpression(DialerImpression.Type.LIGHTBRINGER_VIDEO_REQUESTED_FROM_CALL_LOG); + if (isNonContactEntry(info)) { + Logger.get(mContext) + .logImpression( + DialerImpression.Type.LIGHTBRINGER_NON_CONTACT_VIDEO_REQUESTED_FROM_CALL_LOG); + } startLightbringerActivity(intent); } else if (CallDetailsActivity.isLaunchIntent(intent)) { PerformanceReport.recordClick(UiAction.Type.OPEN_CALL_DETAIL); @@ -942,6 +948,13 @@ public final class CallLogListItemViewHolder extends RecyclerView.ViewHolder } } + private static boolean isNonContactEntry(ContactInfo info) { + if (info == null || info.sourceType != Type.SOURCE_TYPE_DIRECTORY) { + return true; + } + return false; + } + private void startLightbringerActivity(Intent intent) { try { Activity activity = (Activity) mContext; -- cgit v1.2.3