From cf6b73283318a3e35f3483581bdde5a0766bd72b Mon Sep 17 00:00:00 2001
From: wangqi <wangqi@google.com>
Date: Tue, 18 Jul 2017 13:10:29 -0700
Subject: Remove unnecessary background in call log.

Background in call log fragment is same as the activity. It's unnecessary and only reduces rending performances.
Verified by hand that it looks same as before.

GPU Overdraw:
Before: https://screenshot.googleplex.com/y1HNFiae1j7
After: https://screenshot.googleplex.com/mQFxyWEhkFm

Performance test:

Before:

Total frames rendered: 668
Janky frames: 35 (5.24%)
50th percentile: 7ms
90th percentile: 11ms
95th percentile: 16ms
99th percentile: 73ms
Number Missed Vsync: 18
Number High input latency: 1
Number Slow UI thread: 35
Number Slow bitmap uploads: 0
Number Slow issue draw commands: 2

After:

Total frames rendered: 736
Janky frames: 32 (4.35%)
50th percentile: 6ms
90th percentile: 11ms
95th percentile: 13ms
99th percentile: 61ms
Number Missed Vsync: 15
Number High input latency: 0
Number Slow UI thread: 31
Number Slow bitmap uploads: 0
Number Slow issue draw commands: 3

Test: manual
PiperOrigin-RevId: 162392495
Change-Id: I726cd06518d282abe68eb1ff16db82c9a3e6d291
---
 java/com/android/dialer/app/res/layout/call_log_fragment.xml | 2 --
 java/com/android/dialer/app/res/values/colors.xml            | 1 -
 2 files changed, 3 deletions(-)

(limited to 'java/com/android/dialer/app')

diff --git a/java/com/android/dialer/app/res/layout/call_log_fragment.xml b/java/com/android/dialer/app/res/layout/call_log_fragment.xml
index bbfe4e3c9..8bbec95cd 100644
--- a/java/com/android/dialer/app/res/layout/call_log_fragment.xml
+++ b/java/com/android/dialer/app/res/layout/call_log_fragment.xml
@@ -18,7 +18,6 @@
 <LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"
   android:layout_width="match_parent"
   android:layout_height="match_parent"
-  android:background="@color/background_dialer_call_log"
   android:orientation="vertical">
 
   <LinearLayout
@@ -64,7 +63,6 @@
     android:paddingBottom="@dimen/floating_action_button_list_bottom_padding"
     android:paddingStart="@dimen/call_log_horizontal_margin"
     android:paddingEnd="@dimen/call_log_horizontal_margin"
-    android:background="@color/background_dialer_call_log"
     android:clipToPadding="false"/>
 
   <com.android.dialer.widget.EmptyContentView
diff --git a/java/com/android/dialer/app/res/values/colors.xml b/java/com/android/dialer/app/res/values/colors.xml
index 2f6d87b49..7a08dcadb 100644
--- a/java/com/android/dialer/app/res/values/colors.xml
+++ b/java/com/android/dialer/app/res/values/colors.xml
@@ -54,7 +54,6 @@
 
   <!-- Background color for search results and call details -->
   <color name="background_dialer_results">#f9f9f9</color>
-  <color name="background_dialer_call_log">@color/background_dialer_light</color>
 
   <!-- Color of the 1dp divider that separates favorites -->
   <color name="favorite_contacts_separator_color">#d0d0d0</color>
-- 
cgit v1.2.3