From 0f47b8b7b33a39b1bc49ac86b82e3949296ef9f0 Mon Sep 17 00:00:00 2001 From: twyen Date: Thu, 14 Dec 2017 17:41:53 -0800 Subject: Remove voicemail settings if missing permission Bug: 70282673 Test: DialerSettingsActivityTest PiperOrigin-RevId: 179124385 Change-Id: I9a7f8edc4ae8df44891f551a8aa561bd81922f66 --- java/com/android/dialer/app/settings/DialerSettingsActivity.java | 6 ++++++ 1 file changed, 6 insertions(+) (limited to 'java/com/android/dialer/app') diff --git a/java/com/android/dialer/app/settings/DialerSettingsActivity.java b/java/com/android/dialer/app/settings/DialerSettingsActivity.java index 641095512..fc56fa7e0 100644 --- a/java/com/android/dialer/app/settings/DialerSettingsActivity.java +++ b/java/com/android/dialer/app/settings/DialerSettingsActivity.java @@ -40,6 +40,7 @@ import com.android.dialer.common.LogUtil; import com.android.dialer.compat.telephony.TelephonyManagerCompat; import com.android.dialer.configprovider.ConfigProviderBindings; import com.android.dialer.proguard.UsedByReflection; +import com.android.dialer.util.PermissionsUtil; import com.android.dialer.voicemail.settings.VoicemailSettingsFragment; import com.android.voicemail.VoicemailClient; import java.util.List; @@ -194,6 +195,11 @@ public class DialerSettingsActivity extends AppCompatPreferenceActivity { return; } + if (!PermissionsUtil.hasReadPhoneStatePermissions(this)) { + LogUtil.i("DialerSettingsActivity.addVoicemailSettings", "Missing READ_PHONE_STATE"); + return; + } + LogUtil.i("DialerSettingsActivity.addVoicemailSettings", "adding voicemail settings"); Header voicemailSettings = new Header(); voicemailSettings.titleRes = R.string.voicemail_settings_label; -- cgit v1.2.3