From 929674acc5ff2798b767692bbad4143575d31c3b Mon Sep 17 00:00:00 2001 From: calderwoodra Date: Fri, 18 Aug 2017 15:03:13 -0700 Subject: Refactor dialpad fragment out of dialer/app to be reused in nui This change updates a few things: - Adds a listener for the dialpad to call into dialtacts activity - updates FragmentUtils to accept non-support fragments - migrates a few other related (tightly coupled) classes to their own package - general QoL changes Bug: 37748839,37208802 Test: existing PiperOrigin-RevId: 165757904 Change-Id: I506e97ad9a01d07c760e766eccc4d146f8e0931a --- .../res/drawable-hdpi/ic_dialer_fork_add_call.png | Bin 1649 -> 0 bytes .../drawable-hdpi/ic_dialer_fork_current_call.png | Bin 2305 -> 0 bytes .../res/drawable-hdpi/ic_dialer_fork_tt_keypad.png | Bin 2419 -> 0 bytes .../res/drawable-mdpi/ic_dialer_fork_add_call.png | Bin 1309 -> 0 bytes .../drawable-mdpi/ic_dialer_fork_current_call.png | Bin 1581 -> 0 bytes .../res/drawable-mdpi/ic_dialer_fork_tt_keypad.png | Bin 1586 -> 0 bytes .../res/drawable-xhdpi/ic_dialer_fork_add_call.png | Bin 2150 -> 0 bytes .../drawable-xhdpi/ic_dialer_fork_current_call.png | Bin 3154 -> 0 bytes .../drawable-xhdpi/ic_dialer_fork_tt_keypad.png | Bin 3298 -> 0 bytes .../drawable-xxhdpi/ic_dialer_fork_add_call.png | Bin 2583 -> 0 bytes .../ic_dialer_fork_current_call.png | Bin 3622 -> 0 bytes .../drawable-xxhdpi/ic_dialer_fork_tt_keypad.png | Bin 3229 -> 0 bytes .../dialer/app/res/drawable/ic_wifi_calling.xml | 29 -------- .../dialer/app/res/drawable/shadow_fade_left.xml | 24 ------ .../dialer/app/res/drawable/shadow_fade_up.xml | 24 ------ .../app/res/layout-land/dialpad_fragment.xml | 82 --------------------- .../app/res/layout/dialpad_chooser_list_item.xml | 38 ---------- .../dialer/app/res/layout/dialpad_fragment.xml | 72 ------------------ .../dialer/app/res/menu/dialpad_options.xml | 30 -------- java/com/android/dialer/app/res/values/dimens.xml | 3 - .../app/res/values/donottranslate_config.xml | 5 -- java/com/android/dialer/app/res/values/strings.xml | 53 ------------- 22 files changed, 360 deletions(-) delete mode 100755 java/com/android/dialer/app/res/drawable-hdpi/ic_dialer_fork_add_call.png delete mode 100755 java/com/android/dialer/app/res/drawable-hdpi/ic_dialer_fork_current_call.png delete mode 100755 java/com/android/dialer/app/res/drawable-hdpi/ic_dialer_fork_tt_keypad.png delete mode 100644 java/com/android/dialer/app/res/drawable-mdpi/ic_dialer_fork_add_call.png delete mode 100644 java/com/android/dialer/app/res/drawable-mdpi/ic_dialer_fork_current_call.png delete mode 100644 java/com/android/dialer/app/res/drawable-mdpi/ic_dialer_fork_tt_keypad.png delete mode 100644 java/com/android/dialer/app/res/drawable-xhdpi/ic_dialer_fork_add_call.png delete mode 100644 java/com/android/dialer/app/res/drawable-xhdpi/ic_dialer_fork_current_call.png delete mode 100644 java/com/android/dialer/app/res/drawable-xhdpi/ic_dialer_fork_tt_keypad.png delete mode 100644 java/com/android/dialer/app/res/drawable-xxhdpi/ic_dialer_fork_add_call.png delete mode 100644 java/com/android/dialer/app/res/drawable-xxhdpi/ic_dialer_fork_current_call.png delete mode 100644 java/com/android/dialer/app/res/drawable-xxhdpi/ic_dialer_fork_tt_keypad.png delete mode 100644 java/com/android/dialer/app/res/drawable/ic_wifi_calling.xml delete mode 100644 java/com/android/dialer/app/res/drawable/shadow_fade_left.xml delete mode 100644 java/com/android/dialer/app/res/drawable/shadow_fade_up.xml delete mode 100644 java/com/android/dialer/app/res/layout-land/dialpad_fragment.xml delete mode 100644 java/com/android/dialer/app/res/layout/dialpad_chooser_list_item.xml delete mode 100644 java/com/android/dialer/app/res/layout/dialpad_fragment.xml delete mode 100644 java/com/android/dialer/app/res/menu/dialpad_options.xml (limited to 'java/com/android/dialer/app/res') diff --git a/java/com/android/dialer/app/res/drawable-hdpi/ic_dialer_fork_add_call.png b/java/com/android/dialer/app/res/drawable-hdpi/ic_dialer_fork_add_call.png deleted file mode 100755 index 4e0d5649e..000000000 Binary files a/java/com/android/dialer/app/res/drawable-hdpi/ic_dialer_fork_add_call.png and /dev/null differ diff --git a/java/com/android/dialer/app/res/drawable-hdpi/ic_dialer_fork_current_call.png b/java/com/android/dialer/app/res/drawable-hdpi/ic_dialer_fork_current_call.png deleted file mode 100755 index 2cf41d598..000000000 Binary files a/java/com/android/dialer/app/res/drawable-hdpi/ic_dialer_fork_current_call.png and /dev/null differ diff --git a/java/com/android/dialer/app/res/drawable-hdpi/ic_dialer_fork_tt_keypad.png b/java/com/android/dialer/app/res/drawable-hdpi/ic_dialer_fork_tt_keypad.png deleted file mode 100755 index 043685fd9..000000000 Binary files a/java/com/android/dialer/app/res/drawable-hdpi/ic_dialer_fork_tt_keypad.png and /dev/null differ diff --git a/java/com/android/dialer/app/res/drawable-mdpi/ic_dialer_fork_add_call.png b/java/com/android/dialer/app/res/drawable-mdpi/ic_dialer_fork_add_call.png deleted file mode 100644 index 56ac2a33a..000000000 Binary files a/java/com/android/dialer/app/res/drawable-mdpi/ic_dialer_fork_add_call.png and /dev/null differ diff --git a/java/com/android/dialer/app/res/drawable-mdpi/ic_dialer_fork_current_call.png b/java/com/android/dialer/app/res/drawable-mdpi/ic_dialer_fork_current_call.png deleted file mode 100644 index 16a44a078..000000000 Binary files a/java/com/android/dialer/app/res/drawable-mdpi/ic_dialer_fork_current_call.png and /dev/null differ diff --git a/java/com/android/dialer/app/res/drawable-mdpi/ic_dialer_fork_tt_keypad.png b/java/com/android/dialer/app/res/drawable-mdpi/ic_dialer_fork_tt_keypad.png deleted file mode 100644 index 66df69eac..000000000 Binary files a/java/com/android/dialer/app/res/drawable-mdpi/ic_dialer_fork_tt_keypad.png and /dev/null differ diff --git a/java/com/android/dialer/app/res/drawable-xhdpi/ic_dialer_fork_add_call.png b/java/com/android/dialer/app/res/drawable-xhdpi/ic_dialer_fork_add_call.png deleted file mode 100644 index aff140fcd..000000000 Binary files a/java/com/android/dialer/app/res/drawable-xhdpi/ic_dialer_fork_add_call.png and /dev/null differ diff --git a/java/com/android/dialer/app/res/drawable-xhdpi/ic_dialer_fork_current_call.png b/java/com/android/dialer/app/res/drawable-xhdpi/ic_dialer_fork_current_call.png deleted file mode 100644 index 8975727e0..000000000 Binary files a/java/com/android/dialer/app/res/drawable-xhdpi/ic_dialer_fork_current_call.png and /dev/null differ diff --git a/java/com/android/dialer/app/res/drawable-xhdpi/ic_dialer_fork_tt_keypad.png b/java/com/android/dialer/app/res/drawable-xhdpi/ic_dialer_fork_tt_keypad.png deleted file mode 100644 index 4d48ea9ea..000000000 Binary files a/java/com/android/dialer/app/res/drawable-xhdpi/ic_dialer_fork_tt_keypad.png and /dev/null differ diff --git a/java/com/android/dialer/app/res/drawable-xxhdpi/ic_dialer_fork_add_call.png b/java/com/android/dialer/app/res/drawable-xxhdpi/ic_dialer_fork_add_call.png deleted file mode 100644 index 1657da4e2..000000000 Binary files a/java/com/android/dialer/app/res/drawable-xxhdpi/ic_dialer_fork_add_call.png and /dev/null differ diff --git a/java/com/android/dialer/app/res/drawable-xxhdpi/ic_dialer_fork_current_call.png b/java/com/android/dialer/app/res/drawable-xxhdpi/ic_dialer_fork_current_call.png deleted file mode 100644 index f25cce695..000000000 Binary files a/java/com/android/dialer/app/res/drawable-xxhdpi/ic_dialer_fork_current_call.png and /dev/null differ diff --git a/java/com/android/dialer/app/res/drawable-xxhdpi/ic_dialer_fork_tt_keypad.png b/java/com/android/dialer/app/res/drawable-xxhdpi/ic_dialer_fork_tt_keypad.png deleted file mode 100644 index 7ac4d8b58..000000000 Binary files a/java/com/android/dialer/app/res/drawable-xxhdpi/ic_dialer_fork_tt_keypad.png and /dev/null differ diff --git a/java/com/android/dialer/app/res/drawable/ic_wifi_calling.xml b/java/com/android/dialer/app/res/drawable/ic_wifi_calling.xml deleted file mode 100644 index 968713376..000000000 --- a/java/com/android/dialer/app/res/drawable/ic_wifi_calling.xml +++ /dev/null @@ -1,29 +0,0 @@ - - - - - - - \ No newline at end of file diff --git a/java/com/android/dialer/app/res/drawable/shadow_fade_left.xml b/java/com/android/dialer/app/res/drawable/shadow_fade_left.xml deleted file mode 100644 index 6271a8f86..000000000 --- a/java/com/android/dialer/app/res/drawable/shadow_fade_left.xml +++ /dev/null @@ -1,24 +0,0 @@ - - - - - - diff --git a/java/com/android/dialer/app/res/drawable/shadow_fade_up.xml b/java/com/android/dialer/app/res/drawable/shadow_fade_up.xml deleted file mode 100644 index 86d37a9bc..000000000 --- a/java/com/android/dialer/app/res/drawable/shadow_fade_up.xml +++ /dev/null @@ -1,24 +0,0 @@ - - - - - - \ No newline at end of file diff --git a/java/com/android/dialer/app/res/layout-land/dialpad_fragment.xml b/java/com/android/dialer/app/res/layout-land/dialpad_fragment.xml deleted file mode 100644 index 45ef933cb..000000000 --- a/java/com/android/dialer/app/res/layout-land/dialpad_fragment.xml +++ /dev/null @@ -1,82 +0,0 @@ - - - - - - - - - - - - - - - - - - - - - - - - - - - diff --git a/java/com/android/dialer/app/res/layout/dialpad_chooser_list_item.xml b/java/com/android/dialer/app/res/layout/dialpad_chooser_list_item.xml deleted file mode 100644 index e00529614..000000000 --- a/java/com/android/dialer/app/res/layout/dialpad_chooser_list_item.xml +++ /dev/null @@ -1,38 +0,0 @@ - - - - - - - - - - - diff --git a/java/com/android/dialer/app/res/layout/dialpad_fragment.xml b/java/com/android/dialer/app/res/layout/dialpad_fragment.xml deleted file mode 100644 index 9b95e1fbf..000000000 --- a/java/com/android/dialer/app/res/layout/dialpad_fragment.xml +++ /dev/null @@ -1,72 +0,0 @@ - - - - - - - - - - - - - - - - - - - - - diff --git a/java/com/android/dialer/app/res/menu/dialpad_options.xml b/java/com/android/dialer/app/res/menu/dialpad_options.xml deleted file mode 100644 index 2921ea3bb..000000000 --- a/java/com/android/dialer/app/res/menu/dialpad_options.xml +++ /dev/null @@ -1,30 +0,0 @@ - - - - - - - - diff --git a/java/com/android/dialer/app/res/values/dimens.xml b/java/com/android/dialer/app/res/values/dimens.xml index 90a8bb879..4327fb908 100644 --- a/java/com/android/dialer/app/res/values/dimens.xml +++ b/java/com/android/dialer/app/res/values/dimens.xml @@ -107,9 +107,6 @@ so this extra padding makes the entire touch target 40dp --> 8dp - - 10dp - 16dp 16dp diff --git a/java/com/android/dialer/app/res/values/donottranslate_config.xml b/java/com/android/dialer/app/res/values/donottranslate_config.xml index e7a8e6fc3..0d18d551e 100644 --- a/java/com/android/dialer/app/res/values/donottranslate_config.xml +++ b/java/com/android/dialer/app/res/values/donottranslate_config.xml @@ -29,9 +29,4 @@ keys, but for maximum flexibility it's controlled by a flag here (which can be overridden on a per-product basis.) --> true - - - - diff --git a/java/com/android/dialer/app/res/values/strings.xml b/java/com/android/dialer/app/res/values/strings.xml index 5549881c3..4a7c68f91 100644 --- a/java/com/android/dialer/app/res/values/strings.xml +++ b/java/com/android/dialer/app/res/values/strings.xml @@ -176,12 +176,6 @@ --> search - - dial - Show all calls - - Add 2-sec pause - Add wait - Settings @@ -264,21 +254,6 @@ All contacts - - Use touch tone keypad - - - Return to call in progress - - - Add call - Incoming calls @@ -381,9 +356,6 @@ Start voice search - - Call %s - Voicemail @@ -425,34 +397,9 @@ %1$s \u2022 %2$s - - Can\'t call this number - - - To set up voicemail, go to Menu > Settings. - - - To call voicemail, first turn off Airplane mode. - Loading\u2026 - - IMEI - - - MEID - - - Loading from SIM card\u2026 - - - SIM card contacts - Voice search not available -- cgit v1.2.3