From 70fedf8d6caee1177ee891bbfff404dc48867c16 Mon Sep 17 00:00:00 2001
From: mdooley <mdooley@google.com>
Date: Thu, 23 Nov 2017 08:31:05 -0800
Subject: Adding transcription rating feedback

Allow users who have agreed to donate their voicemails to also provide
transcription quality feedback.

screenshot:
https://drive.google.com/open?id=0B9o_KvtLkcuIajVtdFN3Y0Qydmx2NXJYN2N3OVA3N0h5UEdR

Bug: 68712148
Test: manual and new unit tests
PiperOrigin-RevId: 176774942
Change-Id: I08b9afbbefaedfb0de5199038a1d2769bd983855
---
 .../dialer/app/res/layout/call_log_list_item.xml   | 48 +++++++++++++++++++++-
 java/com/android/dialer/app/res/values/colors.xml  |  2 +
 java/com/android/dialer/app/res/values/strings.xml | 31 ++++++++++++++
 java/com/android/dialer/app/res/values/styles.xml  | 15 +++++++
 4 files changed, 95 insertions(+), 1 deletion(-)

(limited to 'java/com/android/dialer/app/res')

diff --git a/java/com/android/dialer/app/res/layout/call_log_list_item.xml b/java/com/android/dialer/app/res/layout/call_log_list_item.xml
index e0f9e63b4..75c8fe6e2 100644
--- a/java/com/android/dialer/app/res/layout/call_log_list_item.xml
+++ b/java/com/android/dialer/app/res/layout/call_log_list_item.xml
@@ -150,7 +150,7 @@
 
           <LinearLayout
             android:id="@+id/transcription"
-            android:layout_width="wrap_content"
+            android:layout_width="match_parent"
             android:layout_height="wrap_content"
             android:layout_marginTop="@dimen/call_log_icon_margin"
             android:visibility="gone"
@@ -174,8 +174,54 @@
               android:textSize="@dimen/call_log_voicemail_transcription_text_size"
               android:focusable="true"
               android:nextFocusUp="@id/voicemail_transcription"
+              android:nextFocusDown="@+id/voicemail_transcription_rating"
               android:paddingTop="2dp"/>
 
+            <LinearLayout
+                android:id="@+id/voicemail_transcription_rating"
+                android:layout_width="match_parent"
+                android:layout_height="wrap_content"
+                android:layout_marginTop="@dimen/call_log_icon_margin"
+                android:layout_gravity="center_vertical"
+                android:visibility="gone"
+                android:paddingTop="2dp"
+                android:orientation="horizontal">
+
+              <TextView
+                  style="@style/TranscriptionQualityRating"
+                  android:id="@+id/voicemail_transcription_rating_text"
+                  android:layout_width="wrap_content"
+                  android:layout_height="wrap_content"
+                  android:layout_weight="1"
+                  android:gravity="start"
+                  android:text="@string/voicemail_transcription_rating"/>
+
+              <TextView
+                  style="@style/TranscriptionQualityRatingLink"
+                  android:id="@+id/voicemail_transcription_rating_good"
+                  android:layout_width="wrap_content"
+                  android:layout_height="wrap_content"
+                  android:gravity="end"
+                  android:text="@string/voicemail_transcription_rating_good"/>
+
+              <TextView
+                  style="@style/TranscriptionQualityRating"
+                  android:id="@+id/voicemail_transcription_rating_separator"
+                  android:layout_width="wrap_content"
+                  android:layout_height="wrap_content"
+                  android:gravity="end"
+                  android:text="@string/voicemail_transcription_rating_separator"/>
+
+              <TextView
+                  style="@style/TranscriptionQualityRatingLink"
+                  android:id="@+id/voicemail_transcription_rating_bad"
+                  android:layout_width="wrap_content"
+                  android:layout_height="wrap_content"
+                  android:gravity="end"
+                  android:text="@string/voicemail_transcription_rating_bad"/>
+
+            </LinearLayout>
+
           </LinearLayout>
 
         </LinearLayout>
diff --git a/java/com/android/dialer/app/res/values/colors.xml b/java/com/android/dialer/app/res/values/colors.xml
index f1f5002ed..84a381f21 100644
--- a/java/com/android/dialer/app/res/values/colors.xml
+++ b/java/com/android/dialer/app/res/values/colors.xml
@@ -34,6 +34,8 @@
   <color name="call_log_voicemail_transcript_color">#de000000</color>
   <!-- 54% black -->
   <color name="call_log_voicemail_transcript_branding_color">#8a000000</color>
+  <!-- 100% blue -->
+  <color name="call_log_voicemail_transcript_rating_color">#ff2a56c6</color>
   <!-- 70% black -->
   <color name="call_log_action_color">#b3000000</color>
   <!-- 54% black -->
diff --git a/java/com/android/dialer/app/res/values/strings.xml b/java/com/android/dialer/app/res/values/strings.xml
index 485bd8994..01c477680 100644
--- a/java/com/android/dialer/app/res/values/strings.xml
+++ b/java/com/android/dialer/app/res/values/strings.xml
@@ -665,6 +665,37 @@
        [CHAR LIMIT=64] -->
   <string name="voicemail_transcription_failed_no_speech">Transcript not available. No speech detected.</string>
 
+  <!-- Prompt asking the user to rate the quality of the voicemail transcription [CHAR LIMIT=30]
+       voicemail_transcription_rating, voicemail_transcription_rating_good,
+       voicemail_transcription_rating_separator and voicemail_transcription_rating_bad are
+       used together to form the rating prompt: 'Rate transcription quality   Good or Bad'
+       where 'Good' and 'Bad' are clickable links. -->
+  <string name="voicemail_transcription_rating">Rate transcription quality</string>
+
+  <!-- Rating choice indicating that the voicemail transcription was good [CHAR LIMIT=10]
+       voicemail_transcription_rating, voicemail_transcription_rating_good,
+       voicemail_transcription_rating_separator and voicemail_transcription_rating_bad are
+       used together to form the rating prompt: 'Rate transcription quality   Good or Bad'
+       where 'Good' and 'Bad' are clickable links. -->
+  <string name="voicemail_transcription_rating_good">Good</string>
+
+  <!-- Rating choice indicating that the voicemail transcription was bad [CHAR LIMIT=10]
+       voicemail_transcription_rating, voicemail_transcription_rating_good,
+       voicemail_transcription_rating_separator and voicemail_transcription_rating_bad are
+       used together to form the rating prompt: 'Rate transcription quality   Good or Bad'
+       where 'Good' and 'Bad' are clickable links. -->
+  <string name="voicemail_transcription_rating_bad">Bad</string>
+
+  <!-- Separator between the good and bad transcription rating choices [CHAR LIMIT=10]
+       voicemail_transcription_rating, voicemail_transcription_rating_good,
+       voicemail_transcription_rating_separator and voicemail_transcription_rating_bad are
+       used together to form the rating prompt: 'Rate transcription quality   Good or Bad'
+       where 'Good' and 'Bad' are clickable links. -->
+  <string name="voicemail_transcription_rating_separator"> or </string>
+
+  <!-- Message displayed after user has rated a voicemail transcription [CHAR LIMIT=30] -->
+  <string name="voicemail_transcription_rating_thanks">Thanks for your feedback</string>
+
   <!-- Button text to prompt a user to open an sms conversation [CHAR LIMIT=NONE] -->
   <string name="view_conversation">View</string>
 
diff --git a/java/com/android/dialer/app/res/values/styles.xml b/java/com/android/dialer/app/res/values/styles.xml
index d464ca7f2..c26821023 100644
--- a/java/com/android/dialer/app/res/values/styles.xml
+++ b/java/com/android/dialer/app/res/values/styles.xml
@@ -251,4 +251,19 @@
     <item name="android:layout_height">1dp</item>
     <item name="android:background">?android:attr/listDivider</item>
   </style>
+
+  <style name="TranscriptionQualityRating">
+    <item name="android:textColor">@color/call_log_voicemail_transcript_branding_color</item>
+    <item name="android:textSize">@dimen/call_log_voicemail_transcription_text_size</item>
+  </style>
+
+  <style name="TranscriptionQualityRatingLink">
+    <item name="android:textColor">@color/call_log_voicemail_transcript_rating_color</item>
+    <item name="android:textSize">@dimen/call_log_voicemail_transcription_text_size</item>
+    <item name="android:paddingTop">8dp</item>
+    <item name="android:paddingBottom">8dp</item>
+    <item name="android:paddingLeft">4dp</item>
+    <item name="android:paddingRight">4dp</item>
+    <item name="android:minHeight">48dp</item>
+  </style>
 </resources>
-- 
cgit v1.2.3