From f8a0caa1c7f9a7c73e59457c746baf703bc4cb17 Mon Sep 17 00:00:00 2001 From: calderwoodra Date: Mon, 12 Mar 2018 18:31:57 -0700 Subject: Don't fetch calls if the parent doesn't exist. This CL is a continuation of cl/187700318. In that CL, we were able to unregister the call log's content observer and prevent this crash, but it's reshowing itself in voicemail now. Since the voicemail's observer is registered in the adapter and is unaware of lifecycle changes, it's much more invasive to fix. So as a quick bandaid, we'll just check that the parent isn't null. Bug: 73972084 Test: n/a PiperOrigin-RevId: 188812159 Change-Id: I533114de66b52395b0f3c90d4ec7a927c4df707f --- java/com/android/dialer/app/calllog/CallLogFragment.java | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) (limited to 'java/com/android/dialer/app/calllog') diff --git a/java/com/android/dialer/app/calllog/CallLogFragment.java b/java/com/android/dialer/app/calllog/CallLogFragment.java index 816801437..4e968f095 100644 --- a/java/com/android/dialer/app/calllog/CallLogFragment.java +++ b/java/com/android/dialer/app/calllog/CallLogFragment.java @@ -489,7 +489,10 @@ public class CallLogFragment extends Fragment @Override public void fetchCalls() { callLogQueryHandler.fetchCalls(callTypeFilter, dateLimit); - if (!isCallLogActivity && getActivity() != null && !getActivity().isFinishing()) { + if (!isCallLogActivity + && getActivity() != null + && !getActivity().isFinishing() + && FragmentUtils.getParent(this, CallLogFragmentListener.class) != null) { FragmentUtils.getParentUnsafe(this, CallLogFragmentListener.class).updateTabUnreadCounts(); } } -- cgit v1.2.3