From 0cd36a6e3bfda1c8b78c0375225929f50ee408a5 Mon Sep 17 00:00:00 2001 From: zachh Date: Tue, 31 Oct 2017 12:04:05 -0700 Subject: Removed helper methods in DialerExecutors. We now use dagger everywhere for consistency and explicitness. Test: tap PiperOrigin-RevId: 174071122 Change-Id: I15d2f8261a7b753353be9e7d3b80692aa0c1b64d --- .../dialer/app/calllog/MissedCallNotificationReceiver.java | 8 +++++--- .../dialer/app/calllog/VisualVoicemailCallLogFragment.java | 7 ++++--- .../com/android/dialer/app/calllog/VisualVoicemailUpdateTask.java | 6 ++++-- 3 files changed, 13 insertions(+), 8 deletions(-) (limited to 'java/com/android/dialer/app/calllog') diff --git a/java/com/android/dialer/app/calllog/MissedCallNotificationReceiver.java b/java/com/android/dialer/app/calllog/MissedCallNotificationReceiver.java index 744c0de74..641be854a 100644 --- a/java/com/android/dialer/app/calllog/MissedCallNotificationReceiver.java +++ b/java/com/android/dialer/app/calllog/MissedCallNotificationReceiver.java @@ -21,7 +21,7 @@ import android.content.Context; import android.content.Intent; import android.support.v4.util.Pair; import com.android.dialer.common.LogUtil; -import com.android.dialer.common.concurrent.DialerExecutors; +import com.android.dialer.common.concurrent.DialerExecutorComponent; import me.leolin.shortcutbadger.ShortcutBadger; /** @@ -30,7 +30,7 @@ import me.leolin.shortcutbadger.ShortcutBadger; */ public class MissedCallNotificationReceiver extends BroadcastReceiver { - //TODO: Use compat class for these methods. + // TODO: Use compat class for these methods. public static final String ACTION_SHOW_MISSED_CALLS_NOTIFICATION = "android.telecom.action.SHOW_MISSED_CALLS_NOTIFICATION"; @@ -53,7 +53,9 @@ public class MissedCallNotificationReceiver extends BroadcastReceiver { PendingResult pendingResult = goAsync(); - DialerExecutors.createNonUiTaskBuilder(context, MissedCallNotifier.getInstance(context)) + DialerExecutorComponent.get(context) + .dialerExecutorFactory() + .createNonUiTaskBuilder(MissedCallNotifier.getInstance(context)) .onSuccess( output -> { LogUtil.i( diff --git a/java/com/android/dialer/app/calllog/VisualVoicemailCallLogFragment.java b/java/com/android/dialer/app/calllog/VisualVoicemailCallLogFragment.java index 9d8b04036..33fcba002 100644 --- a/java/com/android/dialer/app/calllog/VisualVoicemailCallLogFragment.java +++ b/java/com/android/dialer/app/calllog/VisualVoicemailCallLogFragment.java @@ -38,7 +38,7 @@ import com.android.dialer.app.voicemail.error.VoicemailStatus; import com.android.dialer.app.voicemail.error.VoicemailStatusWorker; import com.android.dialer.common.LogUtil; import com.android.dialer.common.concurrent.DialerExecutor; -import com.android.dialer.common.concurrent.DialerExecutors; +import com.android.dialer.common.concurrent.DialerExecutorComponent; import com.android.dialer.logging.DialerImpression; import com.android.dialer.logging.Logger; import com.android.dialer.util.PermissionsUtil; @@ -79,8 +79,9 @@ public class VisualVoicemailCallLogFragment extends CallLogFragment { super.onActivityCreated(savedInstanceState); mPreSyncVoicemailStatusCheckExecutor = - DialerExecutors.createUiTaskBuilder( - getContext(), + DialerExecutorComponent.get(getContext()) + .dialerExecutorFactory() + .createUiTaskBuilder( getActivity().getFragmentManager(), "fetchVoicemailStatus", new VoicemailStatusWorker()) diff --git a/java/com/android/dialer/app/calllog/VisualVoicemailUpdateTask.java b/java/com/android/dialer/app/calllog/VisualVoicemailUpdateTask.java index fd0be5f54..e3279ce26 100644 --- a/java/com/android/dialer/app/calllog/VisualVoicemailUpdateTask.java +++ b/java/com/android/dialer/app/calllog/VisualVoicemailUpdateTask.java @@ -31,7 +31,7 @@ import com.android.dialer.blocking.FilteredNumbersUtil; import com.android.dialer.common.Assert; import com.android.dialer.common.LogUtil; import com.android.dialer.common.concurrent.DialerExecutor.Worker; -import com.android.dialer.common.concurrent.DialerExecutors; +import com.android.dialer.common.concurrent.DialerExecutorComponent; import com.android.dialer.notification.DialerNotificationManager; import com.android.dialer.phonenumbercache.ContactInfo; import com.android.dialer.telecom.TelecomUtil; @@ -184,7 +184,9 @@ class VisualVoicemailUpdateTask implements Worker { LogUtil.i("VisualVoicemailUpdateTask.scheduleTask", "update successful"); -- cgit v1.2.3