From d88c3fbaffc0330fd2bb6ce48047680d9540229b Mon Sep 17 00:00:00 2001
From: Santos Cordon <santoscordon@google.com>
Date: Tue, 8 Oct 2013 17:00:19 -0700
Subject: update dialpad state more often.

Noticed while testing proximity sensor that we do not update the dialpad
state sufficiently. We have increased the amount of places in the code
where the dialpad comes up since we first introduced the proximity code
and the callbacks wheren't updated.

This manifested in situations where the proximity sensor was off at time
when it should have been on.
Repro: be in a call, answer a second call (call waiting), bring up
dialpad, hangup second call.  The dialpad would go away but the prox
sensor still thought it was up.

This change moves the callback to proximity sensor to the exact
place where dialpad is shown/hidden in order to catch all instances.

bug:11006867
Change-Id: I7651b4769d035b9bc68d226da3ffb3aea8986e58
---
 InCallUI/src/com/android/incallui/CallButtonPresenter.java | 6 ------
 InCallUI/src/com/android/incallui/InCallActivity.java      | 2 ++
 2 files changed, 2 insertions(+), 6 deletions(-)

(limited to 'InCallUI')

diff --git a/InCallUI/src/com/android/incallui/CallButtonPresenter.java b/InCallUI/src/com/android/incallui/CallButtonPresenter.java
index 36426302f..3b1411be1 100644
--- a/InCallUI/src/com/android/incallui/CallButtonPresenter.java
+++ b/InCallUI/src/com/android/incallui/CallButtonPresenter.java
@@ -33,7 +33,6 @@ public class CallButtonPresenter extends Presenter<CallButtonPresenter.CallButto
         implements InCallStateListener, AudioModeListener, IncomingCallListener {
 
     private Call mCall;
-    private ProximitySensor mProximitySensor;
     private boolean mAutomaticallyMuted = false;
     private boolean mPreviousMuteState = false;
 
@@ -49,7 +48,6 @@ public class CallButtonPresenter extends Presenter<CallButtonPresenter.CallButto
     public void onUiReady(CallButtonUi ui) {
         super.onUiReady(ui);
 
-        mProximitySensor = InCallPresenter.getInstance().getProximitySensor();
         AudioModeProvider.getInstance().addListener(this);
 
         // register for call state changes last
@@ -64,8 +62,6 @@ public class CallButtonPresenter extends Presenter<CallButtonPresenter.CallButto
         InCallPresenter.getInstance().removeListener(this);
         AudioModeProvider.getInstance().removeListener(this);
         InCallPresenter.getInstance().removeIncomingCallListener(this);
-
-        mProximitySensor = null;
     }
 
     @Override
@@ -210,8 +206,6 @@ public class CallButtonPresenter extends Presenter<CallButtonPresenter.CallButto
     public void showDialpadClicked(boolean checked) {
         Log.v(this, "Show dialpad " + String.valueOf(checked));
         getUi().displayDialpad(checked);
-        mProximitySensor.onDialpadVisible(checked);
-
         updateExtraButtonRow();
     }
 
diff --git a/InCallUI/src/com/android/incallui/InCallActivity.java b/InCallUI/src/com/android/incallui/InCallActivity.java
index ac21d52a2..58db132a6 100644
--- a/InCallUI/src/com/android/incallui/InCallActivity.java
+++ b/InCallUI/src/com/android/incallui/InCallActivity.java
@@ -389,6 +389,8 @@ public class InCallActivity extends Activity {
             mDialpadFragment.setVisible(false);
             mCallCardFragment.setVisible(true);
         }
+
+        InCallPresenter.getInstance().getProximitySensor().onDialpadVisible(showDialpad);
     }
 
     public boolean isDialpadVisible() {
-- 
cgit v1.2.3