From 14e534ea65d09cc473c1c85657d0fefc0d999a88 Mon Sep 17 00:00:00 2001 From: calderwoodra Date: Fri, 3 Nov 2017 16:47:12 -0700 Subject: Added phone paused icon to on hold banner. Public-Origin-Change-Id: If22474d96ee53ce4f7c31fac828fb56022f4fa49 Signed-off-by: Allen Calderwood Author: Kitta Koutarou Bug: 62440523 Test: manual PiperOrigin-RevId: 174532793 Change-Id: I436307d42f42387c3d37eb79c99ef9200703d57f --- java/com/android/incallui/hold/OnHoldFragment.java | 2 +- .../incallui/hold/res/layout/incall_on_hold_banner.xml | 17 ++++++++++++++++- 2 files changed, 17 insertions(+), 2 deletions(-) diff --git a/java/com/android/incallui/hold/OnHoldFragment.java b/java/com/android/incallui/hold/OnHoldFragment.java index c6952131b..33ca158d3 100644 --- a/java/com/android/incallui/hold/OnHoldFragment.java +++ b/java/com/android/incallui/hold/OnHoldFragment.java @@ -68,7 +68,7 @@ public class OnHoldFragment extends Fragment { .setImageResource( secondaryInfo.isVideoCall ? R.drawable.quantum_ic_videocam_white_18 - : R.drawable.quantum_ic_call_white_18); + : R.drawable.quantum_ic_phone_paused_vd_theme_24); view.addOnAttachStateChangeListener( new OnAttachStateChangeListener() { @Override diff --git a/java/com/android/incallui/hold/res/layout/incall_on_hold_banner.xml b/java/com/android/incallui/hold/res/layout/incall_on_hold_banner.xml index 6128ae585..728cce2bc 100644 --- a/java/com/android/incallui/hold/res/layout/incall_on_hold_banner.xml +++ b/java/com/android/incallui/hold/res/layout/incall_on_hold_banner.xml @@ -1,4 +1,19 @@ + Date: Fri, 3 Nov 2017 17:11:08 -0700 Subject: Defining transcription feedback API Bug: 68712148 Test: none PiperOrigin-RevId: 174535170 Change-Id: I436335d142f369f8e7c3249463117ffd5c00d6b4 --- .../transcribe/grpc/voicemail_transcription.proto | 38 ++++++++++++++++++++++ 1 file changed, 38 insertions(+) diff --git a/java/com/android/voicemail/impl/transcribe/grpc/voicemail_transcription.proto b/java/com/android/voicemail/impl/transcribe/grpc/voicemail_transcription.proto index b06017075..1790881e7 100644 --- a/java/com/android/voicemail/impl/transcribe/grpc/voicemail_transcription.proto +++ b/java/com/android/voicemail/impl/transcribe/grpc/voicemail_transcription.proto @@ -68,6 +68,18 @@ enum DonationPreference { DONATE = 2; } +// Enum that specifies the user's rating for a voicemail transcription. +enum TranscriptionRatingValue { + // Default but invalid value. + UNSPECIFIED = 0; + + // User indicated that the transcription was good. + GOOD_TRANSCRIPTION = 1; + + // User indicated that the transcription was bad. + BAD_TRANSCRIPTION = 2; +} + // Request for synchronous voicemail transcription. message TranscribeVoicemailRequest { // Voicemail audio file containing the raw bytes we receive from the carrier. @@ -133,6 +145,26 @@ message GetTranscriptResponse { optional string transcript = 2; } +// The rating for a single voicemail transcription. +message TranscriptionRating { + // The id of the voicemail transcription. + optional string transcription_id = 1; + + // The user's rating of the voicemail transcription. + optional TranscriptionRatingValue rating_value = 2; +} + +// Request for uploading transcription ratings. +message TranscriptionFeedbackRequest { + // User feedback indicating the transcription quality for one or more + // voicemails + repeated TranscriptionRating ratings = 1; +} + +// Response for uploading transcription ratings +message TranscriptionFeedbackResponse { +} + // RPC service for transcribing voicemails. service VoicemailTranscriptionService { // Returns a transcript of the given voicemail. @@ -149,6 +181,12 @@ service VoicemailTranscriptionService { // by TranscribeVoicemailAsync. rpc GetTranscript(GetTranscriptRequest) returns (GetTranscriptResponse) { } + + // Uploads user's transcription feedback. Feedback will only be collected from + // user's who have consented to donate their voicemails. + rpc SendTranscriptionFeedback(TranscriptionFeedbackRequest) + returns (TranscriptionFeedbackResponse) { + } } -- cgit v1.2.3