From cdec41fd4165d2fc6d20a70101706a8e4c70b777 Mon Sep 17 00:00:00 2001 From: Andrew Lee Date: Wed, 3 Jun 2015 17:34:39 -0700 Subject: Fix VoicemailStatusHelper unit tests. VoicemailStatusHelperImplTest was broken because of visibility issues caused by recent changes to how we read voicemail status. But, we plan to use this functionality again in the future. Bug: 21471763 Change-Id: I2049d2661c7d0686c8a439ea8a9e5bd20b009dd6 --- src/com/android/dialer/voicemail/VoicemailStatusHelper.java | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/com/android/dialer/voicemail/VoicemailStatusHelper.java b/src/com/android/dialer/voicemail/VoicemailStatusHelper.java index 545691ec9..d790b7764 100644 --- a/src/com/android/dialer/voicemail/VoicemailStatusHelper.java +++ b/src/com/android/dialer/voicemail/VoicemailStatusHelper.java @@ -20,6 +20,8 @@ import android.database.Cursor; import android.net.Uri; import android.provider.VoicemailContract.Status; +import com.google.common.annotations.VisibleForTesting; + import java.util.List; /** @@ -32,6 +34,7 @@ import java.util.List; * this class to check if any message needs to be shown. */ public interface VoicemailStatusHelper { + @VisibleForTesting public class StatusMessage { /** Package of the source on behalf of which this message has to be shown.*/ public final String sourcePackage; @@ -49,6 +52,7 @@ public interface VoicemailStatusHelper { public final int actionMessageId; /** URI for the corrective action, where applicable. Null if no action URI is available. */ public final Uri actionUri; + public StatusMessage(String sourcePackage, int callLogMessageId, int callDetailsMessageId, int actionMessageId, Uri actionUri) { this.sourcePackage = sourcePackage; @@ -75,6 +79,7 @@ public interface VoicemailStatusHelper { * @param cursor The cursor pointing to the query on {@link Status#CONTENT_URI}. The projection * to be used is defined by the implementation class of this interface. */ + @VisibleForTesting public List getStatusMessages(Cursor cursor); /** -- cgit v1.2.3