From c341db0532d8b60ca29aa0becf05a4eec9bdc43e Mon Sep 17 00:00:00 2001 From: Fabrice Di Meglio Date: Wed, 3 Apr 2013 21:11:37 -0700 Subject: Fix for bug #8146846 Phone App should be mirrored for RTL languages - replace left/right properties with start/end ones (Dialer will never be unbundled) - add mirrored version of some drawables - update AndroidManifest Change-Id: Ia7f5b6ad13dd75fe42f1ee763dda5ab18e2d92c7 --- AndroidManifest.xml | 3 +- res/drawable-ldrtl-hdpi/ic_ab_dialer_holo_dark.png | Bin 0 -> 5665 bytes .../ic_call_incoming_holo_dark.png | Bin 0 -> 598 bytes .../ic_call_missed_holo_dark.png | Bin 0 -> 529 bytes .../ic_call_outgoing_holo_dark.png | Bin 0 -> 602 bytes res/drawable-ldrtl-hdpi/ic_dial_action_call.png | Bin 0 -> 7134 bytes ...c_sound_off_speakerphone_disabled_holo_dark.png | Bin 0 -> 5688 bytes .../ic_sound_off_speakerphone_holo_dark.png | Bin 0 -> 5759 bytes .../ic_sound_speakerphone_disabled_holo_dark.png | Bin 0 -> 6381 bytes .../ic_sound_speakerphone_holo_dark.png | Bin 0 -> 6370 bytes res/drawable-ldrtl-mdpi/ic_ab_dialer_holo_dark.png | Bin 0 -> 5014 bytes .../ic_call_incoming_holo_dark.png | Bin 0 -> 399 bytes .../ic_call_missed_holo_dark.png | Bin 0 -> 351 bytes .../ic_call_outgoing_holo_dark.png | Bin 0 -> 370 bytes res/drawable-ldrtl-mdpi/ic_dial_action_call.png | Bin 0 -> 5938 bytes ...c_sound_off_speakerphone_disabled_holo_dark.png | Bin 0 -> 5005 bytes .../ic_sound_off_speakerphone_holo_dark.png | Bin 0 -> 5034 bytes .../ic_sound_speakerphone_disabled_holo_dark.png | Bin 0 -> 5408 bytes .../ic_sound_speakerphone_holo_dark.png | Bin 0 -> 5406 bytes .../ic_ab_dialer_holo_dark.png | Bin 0 -> 6513 bytes .../ic_call_incoming_holo_dark.png | Bin 0 -> 766 bytes .../ic_call_missed_holo_dark.png | Bin 0 -> 672 bytes .../ic_call_outgoing_holo_dark.png | Bin 0 -> 816 bytes res/drawable-ldrtl-xhdpi/ic_dial_action_call.png | Bin 0 -> 8523 bytes ...c_sound_off_speakerphone_disabled_holo_dark.png | Bin 0 -> 6472 bytes .../ic_sound_off_speakerphone_holo_dark.png | Bin 0 -> 6604 bytes .../ic_sound_speakerphone_disabled_holo_dark.png | Bin 0 -> 7505 bytes .../ic_sound_speakerphone_holo_dark.png | Bin 0 -> 7584 bytes res/layout-land/dialpad_fragment.xml | 3 +- .../account_filter_header_for_phone_favorite.xml | 8 ++--- res/layout/call_detail.xml | 36 ++++++++++----------- res/layout/call_detail_history_header.xml | 2 +- res/layout/call_detail_history_item.xml | 6 ++-- res/layout/call_log_fragment.xml | 10 +++--- res/layout/call_log_list_item.xml | 30 ++++++++--------- res/layout/call_log_voicemail_status.xml | 8 ++--- res/layout/dialpad.xml | 7 ++-- res/layout/dialpad_fragment.xml | 5 +-- res/layout/dialtacts_activity.xml | 4 +-- res/layout/dialtacts_custom_action_bar.xml | 6 ++-- res/layout/phone_disambig_item.xml | 4 +-- res/layout/phone_loading_contacts.xml | 4 +-- res/layout/playback_layout.xml | 14 ++++---- res/layout/set_primary_checkbox.xml | 4 +-- src/com/android/dialer/DialtactsActivity.java | 3 +- src/com/android/dialer/PhoneCallDetailsHelper.java | 4 +++ .../android/dialer/list/PhoneFavoriteFragment.java | 6 ++-- 47 files changed, 89 insertions(+), 78 deletions(-) create mode 100644 res/drawable-ldrtl-hdpi/ic_ab_dialer_holo_dark.png create mode 100644 res/drawable-ldrtl-hdpi/ic_call_incoming_holo_dark.png create mode 100644 res/drawable-ldrtl-hdpi/ic_call_missed_holo_dark.png create mode 100644 res/drawable-ldrtl-hdpi/ic_call_outgoing_holo_dark.png create mode 100644 res/drawable-ldrtl-hdpi/ic_dial_action_call.png create mode 100644 res/drawable-ldrtl-hdpi/ic_sound_off_speakerphone_disabled_holo_dark.png create mode 100644 res/drawable-ldrtl-hdpi/ic_sound_off_speakerphone_holo_dark.png create mode 100644 res/drawable-ldrtl-hdpi/ic_sound_speakerphone_disabled_holo_dark.png create mode 100644 res/drawable-ldrtl-hdpi/ic_sound_speakerphone_holo_dark.png create mode 100644 res/drawable-ldrtl-mdpi/ic_ab_dialer_holo_dark.png create mode 100644 res/drawable-ldrtl-mdpi/ic_call_incoming_holo_dark.png create mode 100644 res/drawable-ldrtl-mdpi/ic_call_missed_holo_dark.png create mode 100644 res/drawable-ldrtl-mdpi/ic_call_outgoing_holo_dark.png create mode 100644 res/drawable-ldrtl-mdpi/ic_dial_action_call.png create mode 100644 res/drawable-ldrtl-mdpi/ic_sound_off_speakerphone_disabled_holo_dark.png create mode 100644 res/drawable-ldrtl-mdpi/ic_sound_off_speakerphone_holo_dark.png create mode 100644 res/drawable-ldrtl-mdpi/ic_sound_speakerphone_disabled_holo_dark.png create mode 100644 res/drawable-ldrtl-mdpi/ic_sound_speakerphone_holo_dark.png create mode 100644 res/drawable-ldrtl-xhdpi/ic_ab_dialer_holo_dark.png create mode 100644 res/drawable-ldrtl-xhdpi/ic_call_incoming_holo_dark.png create mode 100644 res/drawable-ldrtl-xhdpi/ic_call_missed_holo_dark.png create mode 100644 res/drawable-ldrtl-xhdpi/ic_call_outgoing_holo_dark.png create mode 100644 res/drawable-ldrtl-xhdpi/ic_dial_action_call.png create mode 100644 res/drawable-ldrtl-xhdpi/ic_sound_off_speakerphone_disabled_holo_dark.png create mode 100644 res/drawable-ldrtl-xhdpi/ic_sound_off_speakerphone_holo_dark.png create mode 100644 res/drawable-ldrtl-xhdpi/ic_sound_speakerphone_disabled_holo_dark.png create mode 100644 res/drawable-ldrtl-xhdpi/ic_sound_speakerphone_holo_dark.png diff --git a/AndroidManifest.xml b/AndroidManifest.xml index eb05186c3..bde0775ba 100644 --- a/AndroidManifest.xml +++ b/AndroidManifest.xml @@ -48,7 +48,8 @@ + android:hardwareAccelerated="true" + android:supportsRtl="true"> diff --git a/res/layout/dialtacts_activity.xml b/res/layout/dialtacts_activity.xml index 35fa00f08..079ce37d1 100644 --- a/res/layout/dialtacts_activity.xml +++ b/res/layout/dialtacts_activity.xml @@ -29,7 +29,7 @@ android:id="@+id/searchButton" android:layout_width="wrap_content" android:layout_height="?android:attr/actionBarSize" - android:layout_gravity="bottom|left" + android:layout_gravity="bottom|start" android:state_enabled="false" android:background="?android:attr/selectableItemBackground" android:contentDescription="@string/description_search_button" @@ -39,7 +39,7 @@ android:id="@+id/overflow_menu" android:layout_width="wrap_content" android:layout_height="?android:attr/actionBarSize" - android:layout_gravity="bottom|right" + android:layout_gravity="bottom|end" android:src="@drawable/ic_menu_overflow" android:contentDescription="@string/action_menu_overflow_description" android:nextFocusLeft="@id/digits" diff --git a/res/layout/dialtacts_custom_action_bar.xml b/res/layout/dialtacts_custom_action_bar.xml index 26e478574..c62e22596 100644 --- a/res/layout/dialtacts_custom_action_bar.xml +++ b/res/layout/dialtacts_custom_action_bar.xml @@ -32,10 +32,10 @@ diff --git a/res/layout/phone_loading_contacts.xml b/res/layout/phone_loading_contacts.xml index f0d33288e..afc3322d1 100644 --- a/res/layout/phone_loading_contacts.xml +++ b/res/layout/phone_loading_contacts.xml @@ -21,7 +21,7 @@ android:layout_height="match_parent" android:minHeight="?android:attr/listPreferredItemHeight" android:orientation="horizontal" - android:gravity="left|center_vertical"> + android:gravity="start|center_vertical"> + android:layout_marginStart="4dip" /> diff --git a/res/layout/playback_layout.xml b/res/layout/playback_layout.xml index 2dfcb4da4..b72ddcad1 100644 --- a/res/layout/playback_layout.xml +++ b/res/layout/playback_layout.xml @@ -31,7 +31,7 @@ @@ -79,12 +79,12 @@ android:thumb="@drawable/seek_bar_thumb" android:thumbOffset="8dip" android:progress="0" - android:paddingLeft="8dip" - android:paddingRight="8dip" + android:paddingStart="8dip" + android:paddingEnd="8dip" android:paddingTop="30dip" android:paddingBottom="20dip" - android:layout_marginRight="64dip" - android:layout_marginLeft="64dip" + android:layout_marginEnd="64dip" + android:layout_marginStart="64dip" android:max="0" android:layout_centerVertical="true" /> @@ -115,7 +115,7 @@ android:background="?android:attr/selectableItemBackground" android:paddingBottom="19dip" android:paddingTop="29dip" - android:layout_alignParentLeft="true" + android:layout_alignParentStart="true" android:layout_centerVertical="true" /> diff --git a/res/layout/set_primary_checkbox.xml b/res/layout/set_primary_checkbox.xml index 8f28ec791..b997327ed 100644 --- a/res/layout/set_primary_checkbox.xml +++ b/res/layout/set_primary_checkbox.xml @@ -18,8 +18,8 @@ xmlns:android="http://schemas.android.com/apk/res/android" android:layout_width="match_parent" android:layout_height="wrap_content" - android:paddingLeft="14dip" - android:paddingRight="15dip" + android:paddingStart="14dip" + android:paddingEnd="15dip" android:orientation="vertical">