From a544dfcb17c4d1a2db5295d1e27ef47b6d0da82c Mon Sep 17 00:00:00 2001 From: roldenburg Date: Wed, 10 Jan 2018 14:13:06 -0800 Subject: Add events for displaying set up or invite buttons Bug: 70034799 Test: GoogleCallLogAdapterTest PiperOrigin-RevId: 181515491 Change-Id: I62dc4d4d4ebb02e8e1e8dce6c6970bb7c8845952 --- java/com/android/dialer/app/calllog/CallLogListItemViewHolder.java | 5 +++++ java/com/android/dialer/logging/dialer_impression.proto | 6 +++++- 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/java/com/android/dialer/app/calllog/CallLogListItemViewHolder.java b/java/com/android/dialer/app/calllog/CallLogListItemViewHolder.java index f8d3a4cd8..5c9411180 100644 --- a/java/com/android/dialer/app/calllog/CallLogListItemViewHolder.java +++ b/java/com/android/dialer/app/calllog/CallLogListItemViewHolder.java @@ -694,6 +694,7 @@ public final class CallLogListItemViewHolder extends RecyclerView.ViewHolder .getBoolean("enable_call_log_duo_invite_button", false)) { inviteVideoButtonView.setTag(IntentProvider.getDuoInviteIntentProvider(number)); inviteVideoButtonView.setVisibility(View.VISIBLE); + Logger.get(context).logImpression(DialerImpression.Type.DUO_CALL_LOG_INVITE_SHOWN); } } else if (duo.isEnabled(context) && !identifiedSpamCall) { if (!duo.isInstalled(context)) { @@ -701,12 +702,16 @@ public final class CallLogListItemViewHolder extends RecyclerView.ViewHolder .getBoolean("enable_call_log_install_duo_button", false)) { setUpVideoButtonView.setTag(IntentProvider.getInstallDuoIntentProvider()); setUpVideoButtonView.setVisibility(View.VISIBLE); + Logger.get(context) + .logImpression(DialerImpression.Type.DUO_CALL_LOG_SET_UP_INSTALL_SHOWN); } } else { if (ConfigProviderBindings.get(context) .getBoolean("enable_call_log_activate_duo_button", false)) { setUpVideoButtonView.setTag(IntentProvider.getSetUpDuoIntentProvider()); setUpVideoButtonView.setVisibility(View.VISIBLE); + Logger.get(context) + .logImpression(DialerImpression.Type.DUO_CALL_LOG_SET_UP_ACTIVATE_SHOWN); } } } diff --git a/java/com/android/dialer/logging/dialer_impression.proto b/java/com/android/dialer/logging/dialer_impression.proto index 27135b35e..f839b1399 100644 --- a/java/com/android/dialer/logging/dialer_impression.proto +++ b/java/com/android/dialer/logging/dialer_impression.proto @@ -12,7 +12,7 @@ message DialerImpression { // Event enums to be used for Impression Logging in Dialer. // It's perfectly acceptable for this enum to be large // Values should be from 1000 to 100000. - // Next Tag: 1324 + // Next Tag: 1327 enum Type { UNKNOWN_AOSP_EVENT_TYPE = 1000; @@ -653,5 +653,9 @@ message DialerImpression { // Bubble appears BUBBLE_V2_SHOW = 1323; + + DUO_CALL_LOG_SET_UP_INSTALL_SHOWN = 1324; + DUO_CALL_LOG_SET_UP_ACTIVATE_SHOWN = 1325; + DUO_CALL_LOG_INVITE_SHOWN = 1326; } } -- cgit v1.2.3