From b66c1d2ff4f4e86b8b8944da1649d9a0d7488abc Mon Sep 17 00:00:00 2001 From: yueg Date: Mon, 13 Nov 2017 12:52:48 -0800 Subject: Use TextUtils.isEmpty() instead of null check. If phoneNumber is empty string, we go to endless loop. Test: ContactDisplayUtilsTest PiperOrigin-RevId: 175573954 Change-Id: If266a15041134dda4b9b365bc77f31b15cf89b32 --- java/com/android/contacts/common/util/ContactDisplayUtils.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/java/com/android/contacts/common/util/ContactDisplayUtils.java b/java/com/android/contacts/common/util/ContactDisplayUtils.java index ff22f2880..a45394f50 100644 --- a/java/com/android/contacts/common/util/ContactDisplayUtils.java +++ b/java/com/android/contacts/common/util/ContactDisplayUtils.java @@ -216,7 +216,7 @@ public class ContactDisplayUtils { return null; } final Spannable spannable = new SpannableString(message); - int start = phoneNumber == null ? -1 : message.indexOf(phoneNumber); + int start = TextUtils.isEmpty(phoneNumber) ? -1 : message.indexOf(phoneNumber); while (start >= 0) { final int end = start + phoneNumber.length(); final TtsSpan ttsSpan = PhoneNumberUtilsCompat.createTtsSpan(phoneNumber); -- cgit v1.2.3