From 51c2bde72ee4674266ac464bea2aba72d217d75f Mon Sep 17 00:00:00 2001 From: Andrew Lee Date: Wed, 6 May 2015 14:36:50 -0700 Subject: Update layouts for call log list item actions. + Add icons for actions. + Revise layouts to match new visual appearance. Call Log actions are now a linear layout with an icon and text. + Some style/redline tweaks. + Temporarily replaced animation logic with LinearLayout, to be revisited. Bug: 20433758 Change-Id: Ia13b6c9f583d673743488f2e93be5593a1fbf8dc --- res/drawable-hdpi/ic_more_horiz_24dp.png | Bin 0 -> 134 bytes res/drawable-hdpi/ic_report_problem_24dp.png | Bin 0 -> 306 bytes res/drawable-hdpi/ic_videocam_24dp.png | Bin 0 -> 267 bytes res/drawable-hdpi/ic_videocam_wht_24dp.png | Bin 267 -> 0 bytes res/drawable-hdpi/ic_voicemail_24dp.png | Bin 0 -> 478 bytes res/drawable-mdpi/ic_more_horiz_24dp.png | Bin 0 -> 109 bytes res/drawable-mdpi/ic_report_problem_24dp.png | Bin 0 -> 236 bytes res/drawable-mdpi/ic_videocam_24dp.png | Bin 0 -> 215 bytes res/drawable-mdpi/ic_videocam_wht_24dp.png | Bin 215 -> 0 bytes res/drawable-mdpi/ic_voicemail_24dp.png | Bin 0 -> 221 bytes res/drawable-xhdpi/ic_more_horiz_24dp.png | Bin 0 -> 161 bytes res/drawable-xhdpi/ic_report_problem_24dp.png | Bin 0 -> 364 bytes res/drawable-xhdpi/ic_videocam_24dp.png | Bin 0 -> 257 bytes res/drawable-xhdpi/ic_videocam_wht_24dp.png | Bin 257 -> 0 bytes res/drawable-xhdpi/ic_voicemail_24dp.png | Bin 0 -> 487 bytes res/drawable-xxhdpi/ic_more_horiz_24dp.png | Bin 0 -> 213 bytes res/drawable-xxhdpi/ic_report_problem_24dp.png | Bin 0 -> 473 bytes res/drawable-xxhdpi/ic_videocam_24dp.png | Bin 0 -> 340 bytes res/drawable-xxhdpi/ic_videocam_wht_24dp.png | Bin 340 -> 0 bytes res/drawable-xxhdpi/ic_voicemail_24dp.png | Bin 0 -> 625 bytes res/drawable-xxxhdpi/ic_more_horiz_24dp.png | Bin 0 -> 267 bytes res/drawable-xxxhdpi/ic_report_problem_24dp.png | Bin 0 -> 590 bytes res/drawable-xxxhdpi/ic_videocam_24dp.png | Bin 0 -> 290 bytes res/drawable-xxxhdpi/ic_voicemail_24dp.png | Bin 0 -> 971 bytes res/drawable/call_log_action_border.xml | 24 +++ res/layout/call_log_list_item.xml | 169 +++++++++++---------- res/layout/call_log_list_item_actions.xml | 82 ++++++---- res/values/colors.xml | 3 +- res/values/dimens.xml | 12 +- res/values/styles.xml | 20 ++- .../dialer/calllog/CallLogListItemViewHolder.java | 39 +---- .../android/dialer/calllog/CallTypeIconsView.java | 2 +- 32 files changed, 200 insertions(+), 151 deletions(-) create mode 100644 res/drawable-hdpi/ic_more_horiz_24dp.png create mode 100644 res/drawable-hdpi/ic_report_problem_24dp.png create mode 100644 res/drawable-hdpi/ic_videocam_24dp.png delete mode 100644 res/drawable-hdpi/ic_videocam_wht_24dp.png create mode 100644 res/drawable-hdpi/ic_voicemail_24dp.png create mode 100644 res/drawable-mdpi/ic_more_horiz_24dp.png create mode 100644 res/drawable-mdpi/ic_report_problem_24dp.png create mode 100644 res/drawable-mdpi/ic_videocam_24dp.png delete mode 100644 res/drawable-mdpi/ic_videocam_wht_24dp.png create mode 100644 res/drawable-mdpi/ic_voicemail_24dp.png create mode 100644 res/drawable-xhdpi/ic_more_horiz_24dp.png create mode 100644 res/drawable-xhdpi/ic_report_problem_24dp.png create mode 100644 res/drawable-xhdpi/ic_videocam_24dp.png delete mode 100644 res/drawable-xhdpi/ic_videocam_wht_24dp.png create mode 100644 res/drawable-xhdpi/ic_voicemail_24dp.png create mode 100644 res/drawable-xxhdpi/ic_more_horiz_24dp.png create mode 100644 res/drawable-xxhdpi/ic_report_problem_24dp.png create mode 100644 res/drawable-xxhdpi/ic_videocam_24dp.png delete mode 100644 res/drawable-xxhdpi/ic_videocam_wht_24dp.png create mode 100644 res/drawable-xxhdpi/ic_voicemail_24dp.png create mode 100644 res/drawable-xxxhdpi/ic_more_horiz_24dp.png create mode 100644 res/drawable-xxxhdpi/ic_report_problem_24dp.png create mode 100644 res/drawable-xxxhdpi/ic_videocam_24dp.png create mode 100644 res/drawable-xxxhdpi/ic_voicemail_24dp.png create mode 100644 res/drawable/call_log_action_border.xml diff --git a/res/drawable-hdpi/ic_more_horiz_24dp.png b/res/drawable-hdpi/ic_more_horiz_24dp.png new file mode 100644 index 000000000..ebfcb6f54 Binary files /dev/null and b/res/drawable-hdpi/ic_more_horiz_24dp.png differ diff --git a/res/drawable-hdpi/ic_report_problem_24dp.png b/res/drawable-hdpi/ic_report_problem_24dp.png new file mode 100644 index 000000000..cebb1c207 Binary files /dev/null and b/res/drawable-hdpi/ic_report_problem_24dp.png differ diff --git a/res/drawable-hdpi/ic_videocam_24dp.png b/res/drawable-hdpi/ic_videocam_24dp.png new file mode 100644 index 000000000..ecfce9446 Binary files /dev/null and b/res/drawable-hdpi/ic_videocam_24dp.png differ diff --git a/res/drawable-hdpi/ic_videocam_wht_24dp.png b/res/drawable-hdpi/ic_videocam_wht_24dp.png deleted file mode 100644 index ecfce9446..000000000 Binary files a/res/drawable-hdpi/ic_videocam_wht_24dp.png and /dev/null differ diff --git a/res/drawable-hdpi/ic_voicemail_24dp.png b/res/drawable-hdpi/ic_voicemail_24dp.png new file mode 100644 index 000000000..03a62e15f Binary files /dev/null and b/res/drawable-hdpi/ic_voicemail_24dp.png differ diff --git a/res/drawable-mdpi/ic_more_horiz_24dp.png b/res/drawable-mdpi/ic_more_horiz_24dp.png new file mode 100644 index 000000000..8c0be8ad6 Binary files /dev/null and b/res/drawable-mdpi/ic_more_horiz_24dp.png differ diff --git a/res/drawable-mdpi/ic_report_problem_24dp.png b/res/drawable-mdpi/ic_report_problem_24dp.png new file mode 100644 index 000000000..04365b98a Binary files /dev/null and b/res/drawable-mdpi/ic_report_problem_24dp.png differ diff --git a/res/drawable-mdpi/ic_videocam_24dp.png b/res/drawable-mdpi/ic_videocam_24dp.png new file mode 100644 index 000000000..cbb5be2ea Binary files /dev/null and b/res/drawable-mdpi/ic_videocam_24dp.png differ diff --git a/res/drawable-mdpi/ic_videocam_wht_24dp.png b/res/drawable-mdpi/ic_videocam_wht_24dp.png deleted file mode 100644 index cbb5be2ea..000000000 Binary files a/res/drawable-mdpi/ic_videocam_wht_24dp.png and /dev/null differ diff --git a/res/drawable-mdpi/ic_voicemail_24dp.png b/res/drawable-mdpi/ic_voicemail_24dp.png new file mode 100644 index 000000000..e5aa7db05 Binary files /dev/null and b/res/drawable-mdpi/ic_voicemail_24dp.png differ diff --git a/res/drawable-xhdpi/ic_more_horiz_24dp.png b/res/drawable-xhdpi/ic_more_horiz_24dp.png new file mode 100644 index 000000000..dbb87ca91 Binary files /dev/null and b/res/drawable-xhdpi/ic_more_horiz_24dp.png differ diff --git a/res/drawable-xhdpi/ic_report_problem_24dp.png b/res/drawable-xhdpi/ic_report_problem_24dp.png new file mode 100644 index 000000000..a43fa3c27 Binary files /dev/null and b/res/drawable-xhdpi/ic_report_problem_24dp.png differ diff --git a/res/drawable-xhdpi/ic_videocam_24dp.png b/res/drawable-xhdpi/ic_videocam_24dp.png new file mode 100644 index 000000000..814e515bc Binary files /dev/null and b/res/drawable-xhdpi/ic_videocam_24dp.png differ diff --git a/res/drawable-xhdpi/ic_videocam_wht_24dp.png b/res/drawable-xhdpi/ic_videocam_wht_24dp.png deleted file mode 100644 index 814e515bc..000000000 Binary files a/res/drawable-xhdpi/ic_videocam_wht_24dp.png and /dev/null differ diff --git a/res/drawable-xhdpi/ic_voicemail_24dp.png b/res/drawable-xhdpi/ic_voicemail_24dp.png new file mode 100644 index 000000000..59126d706 Binary files /dev/null and b/res/drawable-xhdpi/ic_voicemail_24dp.png differ diff --git a/res/drawable-xxhdpi/ic_more_horiz_24dp.png b/res/drawable-xxhdpi/ic_more_horiz_24dp.png new file mode 100644 index 000000000..2036a9c2c Binary files /dev/null and b/res/drawable-xxhdpi/ic_more_horiz_24dp.png differ diff --git a/res/drawable-xxhdpi/ic_report_problem_24dp.png b/res/drawable-xxhdpi/ic_report_problem_24dp.png new file mode 100644 index 000000000..807b9fa18 Binary files /dev/null and b/res/drawable-xxhdpi/ic_report_problem_24dp.png differ diff --git a/res/drawable-xxhdpi/ic_videocam_24dp.png b/res/drawable-xxhdpi/ic_videocam_24dp.png new file mode 100644 index 000000000..c21679891 Binary files /dev/null and b/res/drawable-xxhdpi/ic_videocam_24dp.png differ diff --git a/res/drawable-xxhdpi/ic_videocam_wht_24dp.png b/res/drawable-xxhdpi/ic_videocam_wht_24dp.png deleted file mode 100644 index c21679891..000000000 Binary files a/res/drawable-xxhdpi/ic_videocam_wht_24dp.png and /dev/null differ diff --git a/res/drawable-xxhdpi/ic_voicemail_24dp.png b/res/drawable-xxhdpi/ic_voicemail_24dp.png new file mode 100644 index 000000000..28b8e936a Binary files /dev/null and b/res/drawable-xxhdpi/ic_voicemail_24dp.png differ diff --git a/res/drawable-xxxhdpi/ic_more_horiz_24dp.png b/res/drawable-xxxhdpi/ic_more_horiz_24dp.png new file mode 100644 index 000000000..535f0874e Binary files /dev/null and b/res/drawable-xxxhdpi/ic_more_horiz_24dp.png differ diff --git a/res/drawable-xxxhdpi/ic_report_problem_24dp.png b/res/drawable-xxxhdpi/ic_report_problem_24dp.png new file mode 100644 index 000000000..8683a2ea9 Binary files /dev/null and b/res/drawable-xxxhdpi/ic_report_problem_24dp.png differ diff --git a/res/drawable-xxxhdpi/ic_videocam_24dp.png b/res/drawable-xxxhdpi/ic_videocam_24dp.png new file mode 100644 index 000000000..ed20c0706 Binary files /dev/null and b/res/drawable-xxxhdpi/ic_videocam_24dp.png differ diff --git a/res/drawable-xxxhdpi/ic_voicemail_24dp.png b/res/drawable-xxxhdpi/ic_voicemail_24dp.png new file mode 100644 index 000000000..820ff5066 Binary files /dev/null and b/res/drawable-xxxhdpi/ic_voicemail_24dp.png differ diff --git a/res/drawable/call_log_action_border.xml b/res/drawable/call_log_action_border.xml new file mode 100644 index 000000000..fbb3559ed --- /dev/null +++ b/res/drawable/call_log_action_border.xml @@ -0,0 +1,24 @@ + + + + + + + + + + diff --git a/res/layout/call_log_list_item.xml b/res/layout/call_log_list_item.xml index 5928183f8..af8cb8b03 100644 --- a/res/layout/call_log_list_item.xml +++ b/res/layout/call_log_list_item.xml @@ -35,127 +35,132 @@ android:paddingTop="@dimen/call_log_day_group_padding_top" android:paddingBottom="@dimen/call_log_day_group_padding_bottom" /> - - - - + android:orientation="vertical"> + - - - - + android:focusable="true" + android:nextFocusRight="@+id/call_back_action" + android:nextFocusLeft="@+id/quick_contact_photo" > + + + android:layout_weight="1" + android:orientation="vertical" + android:gravity="center_vertical" + android:layout_marginStart="@dimen/call_log_list_item_info_margin_start"> + + - + android:textColor="?attr/call_log_secondary_text_color" + android:textSize="@dimen/call_log_secondary_text_size" + android:singleLine="true" + android:ellipsize="marquee" + android:visibility="gone" /> + + + + + + + + - + android:background="?android:attr/selectableItemBackgroundBorderless" + android:src="@drawable/ic_card_phone" + android:tint="@color/recent_call_log_item_phone_icon_tint" + android:alpha="0.3" + android:contentDescription="@string/description_call_log_call_action" + android:visibility="gone" /> - + + android:layout_gravity="bottom" /> - - - diff --git a/res/layout/call_log_list_item_actions.xml b/res/layout/call_log_list_item_actions.xml index 8ef92bf1a..43da5d21b 100644 --- a/res/layout/call_log_list_item_actions.xml +++ b/res/layout/call_log_list_item_actions.xml @@ -23,44 +23,70 @@ android:visibility="visible" android:importantForAccessibility="1"> - - - - + android:nextFocusRight="@+id/voicemail_action"> - + + + + + + + android:nextFocusRight="@+id/details_action"> + + + + + + - + android:nextFocusRight="@+id/report_action"> - + + + + + + + android:nextFocusRight="@+id/primary_action_view"> + + + + + + diff --git a/res/values/colors.xml b/res/values/colors.xml index 25f203dac..86ac9be5a 100644 --- a/res/values/colors.xml +++ b/res/values/colors.xml @@ -18,7 +18,7 @@ #333333 - #737373 + #636363 #ff1744 #00c853 @@ -100,4 +100,5 @@ #80ffffff + #eeeeee diff --git a/res/values/dimens.xml b/res/values/dimens.xml index d4a36cfb1..b36b9d67a 100644 --- a/res/values/dimens.xml +++ b/res/values/dimens.xml @@ -28,11 +28,12 @@ 4dp 13dp 8dp - 16dp + 8dp 24dp 2dp 12dp - 56dip + 56dp + 16dp 72dp @@ -103,11 +104,10 @@ 3dp 48dp + 16dp + 24dp 24dp - + 64dp 14sp 14sp diff --git a/res/values/styles.xml b/res/values/styles.xml index 2cd4aa3e6..d41f334af 100644 --- a/res/values/styles.xml +++ b/res/values/styles.xml @@ -158,10 +158,18 @@ always - + + + +