From e336450bd3f9375fca3344ac3d5912689477ff85 Mon Sep 17 00:00:00 2001 From: calderwoodra Date: Tue, 23 Jan 2018 09:43:01 -0800 Subject: Pressing back button twice really quickly no longer crashes dialer. Bug: 72319656 Test: manual PiperOrigin-RevId: 182947143 Change-Id: I70ed303ba8cdb64591ab6debf60eef540aacea73 --- java/com/android/dialer/main/impl/toolbar/SearchBarView.java | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/java/com/android/dialer/main/impl/toolbar/SearchBarView.java b/java/com/android/dialer/main/impl/toolbar/SearchBarView.java index c84b8fc72..95929383b 100644 --- a/java/com/android/dialer/main/impl/toolbar/SearchBarView.java +++ b/java/com/android/dialer/main/impl/toolbar/SearchBarView.java @@ -82,6 +82,10 @@ final class SearchBarView extends FrameLayout { } private void onSearchBackButtonClicked() { + if (!isExpanded) { + return; + } + listener.onSearchBackButtonClicked(); collapse(true); } -- cgit v1.2.3 From f2556612e0b4cba2d536191ea8caf155cc434492 Mon Sep 17 00:00:00 2001 From: erfanian Date: Tue, 23 Jan 2018 09:55:59 -0800 Subject: Update Assisted Dialing references. Test: existing unit tests PiperOrigin-RevId: 182949031 Change-Id: I40955c6e5f4fe06687880d3e9ef4b91ef9c0b371 --- .../dialer/assisteddialing/ConcreteCreator.java | 4 +++- .../compat/telephony/TelephonyManagerCompat.java | 7 +++++-- java/com/android/incallui/call/DialerCall.java | 18 +++++++++++++++++- 3 files changed, 25 insertions(+), 4 deletions(-) diff --git a/java/com/android/dialer/assisteddialing/ConcreteCreator.java b/java/com/android/dialer/assisteddialing/ConcreteCreator.java index a3c96dbdc..c1ffbd396 100644 --- a/java/com/android/dialer/assisteddialing/ConcreteCreator.java +++ b/java/com/android/dialer/assisteddialing/ConcreteCreator.java @@ -23,6 +23,7 @@ import android.os.Build.VERSION_CODES; import android.preference.PreferenceManager; import android.support.annotation.NonNull; import android.support.annotation.VisibleForTesting; +import android.support.v4.os.BuildCompat; import android.support.v4.os.UserManagerCompat; import android.telephony.TelephonyManager; import com.android.dialer.common.LogUtil; @@ -102,7 +103,8 @@ public final class ConcreteCreator { } return (Build.VERSION.SDK_INT >= BUILD_CODE_FLOOR - && Build.VERSION.SDK_INT <= BUILD_CODE_CEILING) + && Build.VERSION.SDK_INT <= BUILD_CODE_CEILING + && !BuildCompat.isAtLeastP()) && configProvider.getBoolean("assisted_dialing_enabled", false); } diff --git a/java/com/android/dialer/compat/telephony/TelephonyManagerCompat.java b/java/com/android/dialer/compat/telephony/TelephonyManagerCompat.java index 92e256998..86f344f4e 100644 --- a/java/com/android/dialer/compat/telephony/TelephonyManagerCompat.java +++ b/java/com/android/dialer/compat/telephony/TelephonyManagerCompat.java @@ -65,8 +65,11 @@ public class TelephonyManagerCompat { public static final String ASSISTED_DIALING_EXTRAS = "android.telecom.extra.ASSISTED_DIALING_EXTRAS"; + public static final String EXTRA_ASSISTED_DIALING_TRANSFORMATION_INFO = + "android.telecom.extra.ASSISTED_DIALING_TRANSFORMATION_INFO"; + /** Indicates the Connection/Call used assisted dialing. */ - public static final int PROPERTY_ASSISTED_DIALING_USED = 0x00000200; + public static final int PROPERTY_ASSISTED_DIALING_USED = 1 << 9; public static final String EXTRA_IS_REFRESH = BuildCompat.isAtLeastOMR1() ? "android.telephony.extra.IS_REFRESH" : "is_refresh"; @@ -75,7 +78,7 @@ public class TelephonyManagerCompat { * Indicates the call underwent Assisted Dialing; typically set as a feature available from the * CallLog. */ - public static final Integer FEATURES_ASSISTED_DIALING = 0x10; + public static final Integer FEATURES_ASSISTED_DIALING = 1 << 4; /** * Returns the number of phones available. Returns 1 for Single standby mode (Single SIM diff --git a/java/com/android/incallui/call/DialerCall.java b/java/com/android/incallui/call/DialerCall.java index 27243225b..a30367f7f 100644 --- a/java/com/android/incallui/call/DialerCall.java +++ b/java/com/android/incallui/call/DialerCall.java @@ -1114,7 +1114,7 @@ public class DialerCall implements VideoTechListener, StateChangedListener, Capa // perform assisted dialing. PROPERTY_ASSISTED_DIALING_USED indicates assisted dialing took // place. if (hasProperty(TelephonyManagerCompat.PROPERTY_ASSISTED_DIALING_USED) - && Build.VERSION.SDK_INT > ConcreteCreator.BUILD_CODE_CEILING) { + && BuildCompat.isAtLeastP()) { return true; } return false; @@ -1126,10 +1126,26 @@ public class DialerCall implements VideoTechListener, StateChangedListener, Capa return null; } + if (BuildCompat.isAtLeastP()) { + if (getExtras() == null) { + return null; + } + + if (getExtras() + .getParcelable(TelephonyManagerCompat.EXTRA_ASSISTED_DIALING_TRANSFORMATION_INFO) + == null) { + return null; + } + + // TODO(erfanian): Use the framework transformation info when we can link against it + return null; + } + if (getIntentExtras().getBundle(TelephonyManagerCompat.ASSISTED_DIALING_EXTRAS) == null) { return null; } + // Used in N-OMR1 return TransformationInfo.newInstanceFromBundle( getIntentExtras().getBundle(TelephonyManagerCompat.ASSISTED_DIALING_EXTRAS)); } -- cgit v1.2.3 From bf7e8854806ce55c7fd298940fca52d013a02e89 Mon Sep 17 00:00:00 2001 From: yueg Date: Tue, 23 Jan 2018 10:00:15 -0800 Subject: Bubble change when display size change. - Set primary button background oval and transparent. - Provide outline for primary button since elevation doesn't work when background is transparent. - Re-draw bubble on configuration changed to propagate changes. Test: manual PiperOrigin-RevId: 182949653 Change-Id: I71e70d6fa43fa5867f9cf37002930c5a8dc42b06 --- java/com/android/newbubble/NewBubble.java | 23 ++++++++++++++++++++-- .../newbubble/res/drawable/bubble_shape_circle.xml | 13 ++++++------ 2 files changed, 27 insertions(+), 9 deletions(-) diff --git a/java/com/android/newbubble/NewBubble.java b/java/com/android/newbubble/NewBubble.java index c0f93e29e..8b188ba33 100644 --- a/java/com/android/newbubble/NewBubble.java +++ b/java/com/android/newbubble/NewBubble.java @@ -25,6 +25,7 @@ import android.annotation.SuppressLint; import android.app.PendingIntent.CanceledException; import android.content.Context; import android.content.Intent; +import android.graphics.Outline; import android.graphics.PixelFormat; import android.graphics.Rect; import android.graphics.drawable.Animatable; @@ -46,6 +47,7 @@ import android.view.MotionEvent; import android.view.View; import android.view.View.AccessibilityDelegate; import android.view.ViewGroup; +import android.view.ViewOutlineProvider; import android.view.ViewTreeObserver.OnPreDrawListener; import android.view.WindowManager; import android.view.WindowManager.LayoutParams; @@ -112,7 +114,7 @@ public class NewBubble { @VisibleForTesting AnimatorSet exitAnimatorSet; @VisibleForTesting AnimatorSet enterAnimatorSet; - private final int primaryIconMoveDistance; + private int primaryIconMoveDistance; private final int leftBoundary; private int savedYPosition = -1; @@ -663,6 +665,22 @@ public class NewBubble { } private void update() { + // The value may change on display size changed. + primaryIconMoveDistance = + context.getResources().getDimensionPixelSize(R.dimen.bubble_size) + - context.getResources().getDimensionPixelSize(R.dimen.bubble_small_icon_size); + // Set boundary for primary button to show elevation (background is transparent) + viewHolder + .getPrimaryButton() + .setOutlineProvider( + new ViewOutlineProvider() { + @Override + public void getOutline(View view, Outline outline) { + ViewOutlineProvider.BACKGROUND.getOutline(view, outline); + outline.setAlpha(1); + } + }); + // Small icon Drawable smallIconBackgroundCircle = context @@ -914,9 +932,10 @@ public class NewBubble { startCollapse(CollapseEnd.NOTHING, false /* shouldRecoverYPosition */); } // The values in the current MoveHandler may be stale, so replace it. Then ensure the - // Window is in bounds + // Window is in bounds, and redraw the changes moveHandler = new NewMoveHandler(primaryButton, NewBubble.this); moveHandler.snapToBounds(); + replaceViewHolder(); }); root.setOnTouchListener( (v, event) -> { diff --git a/java/com/android/newbubble/res/drawable/bubble_shape_circle.xml b/java/com/android/newbubble/res/drawable/bubble_shape_circle.xml index af9d8589b..b188e9d3f 100644 --- a/java/com/android/newbubble/res/drawable/bubble_shape_circle.xml +++ b/java/com/android/newbubble/res/drawable/bubble_shape_circle.xml @@ -15,11 +15,10 @@ ~ limitations under the License --> - - - + + + -- cgit v1.2.3