From f1861059b421d52d3229687bc60a9f4a5a025be3 Mon Sep 17 00:00:00 2001 From: wangqi Date: Thu, 19 Apr 2018 15:06:06 -0700 Subject: Delete DialerCall#onDestroy since it's redudant with onRemovedFromCallList. Test: manual PiperOrigin-RevId: 193581061 Change-Id: Ia28f86c82f94ecd68623cfaa9c401073579358e5 --- java/com/android/incallui/call/CallList.java | 1 - java/com/android/incallui/call/DialerCall.java | 25 +++++++++---------------- 2 files changed, 9 insertions(+), 17 deletions(-) diff --git a/java/com/android/incallui/call/CallList.java b/java/com/android/incallui/call/CallList.java index 04e02c45b..eccdceeca 100644 --- a/java/com/android/incallui/call/CallList.java +++ b/java/com/android/incallui/call/CallList.java @@ -745,7 +745,6 @@ public class CallList implements DialerCallDelegate { call.setState(DialerCall.State.IDLE); updateCallInMap(call); notifyGenericListeners(); - call.onDestroy(); } /** diff --git a/java/com/android/incallui/call/DialerCall.java b/java/com/android/incallui/call/DialerCall.java index 4966110f7..3b7e4dc8f 100644 --- a/java/com/android/incallui/call/DialerCall.java +++ b/java/com/android/incallui/call/DialerCall.java @@ -541,22 +541,6 @@ public class DialerCall implements VideoTechListener, StateChangedListener, Capa return countryIso; } - /** - * Called when call is disconnected and removed from {@link CallList}, UI may already be destroyed - * at this point. This is last chance to do something for the call. - */ - public void onDestroy() { - LogUtil.enterBlock("DialerCall.onDestroy"); - if (rttTranscript != null) { - Futures.addCallback( - RttTranscriptUtil.saveRttTranscript(context, rttTranscript), - new DefaultFutureCallback<>(), - MoreExecutors.directExecutor()); - // Sets to null so it won't be saved again when called multiple times. - rttTranscript = null; - } - } - private void updateIsVoiceMailNumber() { if (getHandle() != null && PhoneAccount.SCHEME_VOICEMAIL.equals(getHandle().getScheme())) { isVoicemailNumber = true; @@ -1608,8 +1592,17 @@ public class DialerCall implements VideoTechListener, StateChangedListener, Capa } void onRemovedFromCallList() { + LogUtil.enterBlock("DialerCall.onRemovedFromCallList"); // Ensure we clean up when this call is removed. videoTechManager.dispatchRemovedFromCallList(); + if (rttTranscript != null) { + Futures.addCallback( + RttTranscriptUtil.saveRttTranscript(context, rttTranscript), + new DefaultFutureCallback<>(), + MoreExecutors.directExecutor()); + // Sets to null so it won't be saved again when called multiple times. + rttTranscript = null; + } } public com.android.dialer.logging.VideoTech.Type getSelectedAvailableVideoTechType() { -- cgit v1.2.3