From 20c2ff76b873471d41abf34b98abb414e4605c36 Mon Sep 17 00:00:00 2001 From: zachh Date: Fri, 13 Oct 2017 17:53:18 -0700 Subject: Fixed crash which occurred when clearing call log containing enriched call data. There was a race where the dialog could sometimes get detached before the success callback finished. The callback would attempt to show a snackbar using [fragment.]getString(), which throws when the fragment is detached. The fix is to just use the activity to get the string (which has already been asserted to be valid). Bug: 65968151 Test: unit PiperOrigin-RevId: 172169503 Change-Id: If86250b14038958e6668b26d1f150619fe3eefae --- java/com/android/dialer/app/calllog/ClearCallLogDialog.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/java/com/android/dialer/app/calllog/ClearCallLogDialog.java b/java/com/android/dialer/app/calllog/ClearCallLogDialog.java index b16eb1beb..197d2dad4 100644 --- a/java/com/android/dialer/app/calllog/ClearCallLogDialog.java +++ b/java/com/android/dialer/app/calllog/ClearCallLogDialog.java @@ -129,7 +129,7 @@ public class ClearCallLogDialog extends DialogFragment { if (EnrichedCallComponent.get(activity).getEnrichedCallManager().hasStoredData()) { Snackbar.make( activity.findViewById(R.id.calllog_frame), - getString(R.string.multiple_ec_data_deleted), + activity.getString(R.string.multiple_ec_data_deleted), 5_000) .show(); } -- cgit v1.2.3