From b33fae243570a1934a03ca37ed6293120b4daf54 Mon Sep 17 00:00:00 2001 From: Nate Jiang Date: Wed, 6 May 2020 15:38:17 -0700 Subject: Add metrics for user revoke permission Revoke permission can happen when user disable in settings or user disallowed from UI. Updated-PDD: TRUE Bug: 154546365 Test: atest com.android.server.wifi Change-Id: I76f0935867dc8a58ede0e1967b1629861e97a6ea --- tests/wifitests/src/com/android/server/wifi/WifiMetricsTest.java | 6 ++++++ .../com/android/server/wifi/WifiNetworkSuggestionsManagerTest.java | 1 + 2 files changed, 7 insertions(+) (limited to 'tests') diff --git a/tests/wifitests/src/com/android/server/wifi/WifiMetricsTest.java b/tests/wifitests/src/com/android/server/wifi/WifiMetricsTest.java index 6506bd8d2..5b73f7a08 100644 --- a/tests/wifitests/src/com/android/server/wifi/WifiMetricsTest.java +++ b/tests/wifitests/src/com/android/server/wifi/WifiMetricsTest.java @@ -4180,6 +4180,9 @@ public class WifiMetricsTest extends WifiBaseTest { mWifiMetrics.addNetworkSuggestionUserApprovalAppUiReaction(1, true); mWifiMetrics.addNetworkSuggestionUserApprovalAppUiReaction(2, false); + mWifiMetrics.incrementNetworkSuggestionUserRevokePermission(); + mWifiMetrics.incrementNetworkSuggestionUserRevokePermission(); + dumpProtoAndDeserialize(); assertEquals(4, mDecodedProto.wifiNetworkSuggestionApiLog.numModification); @@ -4220,6 +4223,9 @@ public class WifiMetricsTest extends WifiBaseTest { assertEquals(false, mDecodedProto.wifiNetworkSuggestionApiLog.userApprovalAppUiReaction[1] .isDialog); + + assertEquals(2, mDecodedProto.wifiNetworkSuggestionApiLog + .userRevokeAppSuggestionPermission); } private NetworkSelectionExperimentDecisions findUniqueNetworkSelectionExperimentDecisions( diff --git a/tests/wifitests/src/com/android/server/wifi/WifiNetworkSuggestionsManagerTest.java b/tests/wifitests/src/com/android/server/wifi/WifiNetworkSuggestionsManagerTest.java index df729bfb1..1bfe20bfe 100644 --- a/tests/wifitests/src/com/android/server/wifi/WifiNetworkSuggestionsManagerTest.java +++ b/tests/wifitests/src/com/android/server/wifi/WifiNetworkSuggestionsManagerTest.java @@ -2040,6 +2040,7 @@ public class WifiNetworkSuggestionsManagerTest extends WifiBaseTest { mLooper.dispatchAll(); verify(mAppOpsManager).stopWatchingMode(mAppOpChangedListenerCaptor.getValue()); assertTrue(mWifiNetworkSuggestionsManager.getAllNetworkSuggestions().isEmpty()); + verify(mWifiMetrics).incrementNetworkSuggestionUserRevokePermission(); } /** -- cgit v1.2.3