From b7de92f5a3cf0113ff4e892c7e536e5b58c2e4f8 Mon Sep 17 00:00:00 2001
From: Hai Shalom <haishalom@google.com>
Date: Fri, 2 Aug 2019 13:32:40 -0700
Subject: [WPA3] Add error logs for WifiConfiguration validation failures

Add informative error logs for WPA3-Personal, WPA3-Enterprise and OWE
validiation checks, specifically missing PMF.

Bug: 138771111
Test: atest WifiConfigurationUtilTest
Change-Id: Ib437afbbad135bede36bb5415db6a17e3cd190b5
---
 service/java/com/android/server/wifi/WifiConfigurationUtil.java | 3 +++
 1 file changed, 3 insertions(+)

(limited to 'service')

diff --git a/service/java/com/android/server/wifi/WifiConfigurationUtil.java b/service/java/com/android/server/wifi/WifiConfigurationUtil.java
index a99253463..59d3eb3f4 100644
--- a/service/java/com/android/server/wifi/WifiConfigurationUtil.java
+++ b/service/java/com/android/server/wifi/WifiConfigurationUtil.java
@@ -602,12 +602,14 @@ public class WifiConfigurationUtil {
         if (config.allowedKeyManagement.get(WifiConfiguration.KeyMgmt.OWE)) {
             // PMF mandatory for OWE networks
             if (!config.requirePMF) {
+                Log.e(TAG, "PMF must be enabled for OWE networks");
                 return false;
             }
         }
         if (config.allowedKeyManagement.get(WifiConfiguration.KeyMgmt.SAE)) {
             // PMF mandatory for WPA3-Personal networks
             if (!config.requirePMF) {
+                Log.e(TAG, "PMF must be enabled for SAE networks");
                 return false;
             }
             if (!validatePassword(config.preSharedKey, isAdd, true)) {
@@ -617,6 +619,7 @@ public class WifiConfigurationUtil {
         if (config.allowedKeyManagement.get(WifiConfiguration.KeyMgmt.SUITE_B_192)) {
             // PMF mandatory for WPA3-Enterprise networks
             if (!config.requirePMF) {
+                Log.e(TAG, "PMF must be enabled for Suite-B 192-bit networks");
                 return false;
             }
         }
-- 
cgit v1.2.3