summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorlinyuh <linyuh@google.com>2018-06-04 14:07:21 -0700
committerCopybara-Service <copybara-piper@google.com>2018-06-04 16:08:18 -0700
commit25bb49e1806c3fef254f11bc17e76ca2bf6e5374 (patch)
treeefae6195d33e3881b63a6817d5b5fa6ff94cfbd9
parent444a3aea729cdc50ba2df51297da22f8e6a59c4b (diff)
Replace TextView with BidiTextView in the new call log where a phone number can be shown.
Bug: 72162627 Test: Existing tests PiperOrigin-RevId: 199190694 Change-Id: I19f2ae7e8af452062672c67eb1be1bc6cc49b855
-rw-r--r--java/com/android/dialer/calllog/ui/res/layout/new_call_log_entry.xml14
-rw-r--r--java/com/android/dialer/historyitemactions/res/layout/contact_layout.xml4
2 files changed, 9 insertions, 9 deletions
diff --git a/java/com/android/dialer/calllog/ui/res/layout/new_call_log_entry.xml b/java/com/android/dialer/calllog/ui/res/layout/new_call_log_entry.xml
index 726c53bc1..5ce87cecf 100644
--- a/java/com/android/dialer/calllog/ui/res/layout/new_call_log_entry.xml
+++ b/java/com/android/dialer/calllog/ui/res/layout/new_call_log_entry.xml
@@ -53,18 +53,18 @@
<!--
Important note:
- The following TextView is the only widget that defines a weight in the containing
+ The following BidiTextView is the only widget that defines a weight in the containing
LinearLayout, of which the purpose is to avoid pushing the widgets after it out of the
boundary when the text is too long.
- Generally it is more efficient to assign a width/height of 0dp so that the TextView does
- not have to measure its own size since it will absorb all the remaining space anyway.
+ Generally it is more efficient to assign a width/height of 0dp so that the BidiTextView
+ does not have to measure its own size since it will absorb all the remaining space anyway.
- However, as the TextView is part of an entry in the call log's RecyclerView, we must set
- layout_width to "wrap_content" so that the TextView can adjust its size when recycled for
- text of different lengths.
+ However, as the BidiTextView is part of an entry in the call log's RecyclerView, we must
+ set layout_width to "wrap_content" so that the TextView can adjust its size when recycled
+ for text of different lengths.
-->
- <TextView
+ <com.android.dialer.widget.BidiTextView
android:id="@+id/primary_text"
style="@style/Dialer.TextAppearance.Primary.Ellipsize"
android:layout_width="wrap_content"
diff --git a/java/com/android/dialer/historyitemactions/res/layout/contact_layout.xml b/java/com/android/dialer/historyitemactions/res/layout/contact_layout.xml
index 5c1678330..247ca0b39 100644
--- a/java/com/android/dialer/historyitemactions/res/layout/contact_layout.xml
+++ b/java/com/android/dialer/historyitemactions/res/layout/contact_layout.xml
@@ -39,13 +39,13 @@
android:gravity="center_vertical"
android:orientation="vertical">
- <TextView
+ <com.android.dialer.widget.BidiTextView
android:id="@+id/primary_text"
style="@style/Dialer.TextAppearance.Primary.Ellipsize"
android:layout_width="wrap_content"
android:layout_height="wrap_content"/>
- <TextView
+ <com.android.dialer.widget.BidiTextView
android:id="@+id/secondary_text"
style="@style/Dialer.TextAppearance.Secondary.Ellipsize"
android:layout_width="wrap_content"